From 85d4a3a5fd6881b07e97fb690d31baef405cfa69 Mon Sep 17 00:00:00 2001 From: Tasso Evangelista Date: Fri, 13 Nov 2020 22:16:10 -0300 Subject: [PATCH] fix: Set a conservative output.environment on Webpack bundles (#330) --- packages/fuselage-ui-kit/webpack.config.js | 17 +++++++++++------ packages/fuselage/webpack.config.js | 11 ++++++++++- packages/ui-kit/.eslintignore | 1 + packages/ui-kit/webpack.config.js | 9 +++++++++ 4 files changed, 31 insertions(+), 7 deletions(-) diff --git a/packages/fuselage-ui-kit/webpack.config.js b/packages/fuselage-ui-kit/webpack.config.js index 5aa0ad1d..05ada8d0 100644 --- a/packages/fuselage-ui-kit/webpack.config.js +++ b/packages/fuselage-ui-kit/webpack.config.js @@ -12,11 +12,20 @@ module.exports = (env, { mode = 'production' }) => ({ 'fuselage-ui-kit': path.resolve(__dirname, 'src/index.js'), }, output: { - filename: `[name].${ mode }.js`, + filename: `[name].${mode}.js`, path: path.resolve(__dirname, 'dist'), library: 'RocketChatFuselageUiKit', libraryTarget: 'umd', umdNamedDefine: true, + environment: { + arrowFunction: false, + bigIntLiteral: false, + const: false, + destructuring: false, + dynamicImport: false, + forOf: false, + module: false, + }, }, devtool: mode === 'production' ? false : 'source-map', module: { @@ -28,11 +37,7 @@ module.exports = (env, { mode = 'production' }) => ({ }, ], }, - externals: [ - 'react', - 'react-dom', - /^@rocket.chat\//, - ], + externals: ['react', 'react-dom', /^@rocket.chat\//], plugins: [ new webpack.DefinePlugin({ 'process.env.VERSION': JSON.stringify(pkg.version), diff --git a/packages/fuselage/webpack.config.js b/packages/fuselage/webpack.config.js index 5dace7ed..2e862ad0 100644 --- a/packages/fuselage/webpack.config.js +++ b/packages/fuselage/webpack.config.js @@ -9,11 +9,20 @@ module.exports = (env, { mode = 'production' }) => ({ fuselage: path.resolve(__dirname, 'src/index.js'), }, output: { - filename: `[name].${ mode }.js`, + filename: `[name].${mode}.js`, path: path.resolve(__dirname, 'dist'), library: 'RocketChatFuselage', libraryTarget: 'umd', umdNamedDefine: true, + environment: { + arrowFunction: false, + bigIntLiteral: false, + const: false, + destructuring: false, + dynamicImport: false, + forOf: false, + module: false, + }, }, devtool: mode === 'production' ? false : 'source-map', module: { diff --git a/packages/ui-kit/.eslintignore b/packages/ui-kit/.eslintignore index 56db724d..e87b4005 100644 --- a/packages/ui-kit/.eslintignore +++ b/packages/ui-kit/.eslintignore @@ -1,3 +1,4 @@ /node_modules /dist !/.eslintrc.js +/webpack.config.js diff --git a/packages/ui-kit/webpack.config.js b/packages/ui-kit/webpack.config.js index 34c75e56..2a35c457 100644 --- a/packages/ui-kit/webpack.config.js +++ b/packages/ui-kit/webpack.config.js @@ -16,6 +16,15 @@ module.exports = (env, argv) => ({ library: 'RocketChatUiKit', libraryTarget: 'umd', umdNamedDefine: true, + environment: { + arrowFunction: false, + bigIntLiteral: false, + const: false, + destructuring: false, + dynamicImport: false, + forOf: false, + module: false, + }, }, resolve: { extensions: ['.ts', '.tsx', '.js'], -- GitLab