accord issueshttps://gitlab.ow2.org/accord/accord/-/issues2018-09-21T20:38:55Zhttps://gitlab.ow2.org/accord/accord/-/issues/10Invalid keystore format blocking two test cases2018-09-21T20:38:55ZRafael MarinsInvalid keystore format blocking two test casesThe testSecureConnection(org.neociclo.odetteftp.client.OftpVer20ClientTest) and testSendingCompressedData(org.neociclo.odetteftp.client.OftpVer20ClientTest) are blocked due to a "java.io.IOException: Invalid keystore format" error on key...The testSecureConnection(org.neociclo.odetteftp.client.OftpVer20ClientTest) and testSendingCompressedData(org.neociclo.odetteftp.client.OftpVer20ClientTest) are blocked due to a "java.io.IOException: Invalid keystore format" error on keystore load.
See attachment for more complete stack trace.oftp-1.2.0.Beta2https://gitlab.ow2.org/accord/accord/-/issues/18Provide configurable external connection templates for OFTP v1.3, v1.4 and v2...2018-09-21T20:38:55ZRafael MarinsProvide configurable external connection templates for OFTP v1.3, v1.4 and v2.0 testingoftp-1.2.0.Beta2https://gitlab.ow2.org/accord/accord/-/issues/23Fix the compression support and add test cases2018-09-21T20:38:55ZRafael MarinsFix the compression support and add test casesoftp-1.2.0.Beta2https://gitlab.ow2.org/accord/accord/-/issues/24Add tests cases for all different file transfer record format2018-09-21T20:38:55ZRafael MarinsAdd tests cases for all different file transfer record formatoftp-1.2.0.Beta2https://gitlab.ow2.org/accord/accord/-/issues/25Provide a very simple Oftp client program example2018-09-21T20:38:55ZRafael MarinsProvide a very simple Oftp client program exampleoftp-1.2.0.Beta2https://gitlab.ow2.org/accord/accord/-/issues/38Migrate underlying OFTP API transport framework to Netty2010-08-11T20:46:17ZRafael MarinsMigrate underlying OFTP API transport framework to Nettyoftp-1.2.0.Beta2https://gitlab.ow2.org/accord/accord/-/issues/47Add warn message for invalid field content on CommandExchangeBuffer2010-10-08T13:45:52ZBruno BorgesAdd warn message for invalid field content on CommandExchangeBufferAs Patrick Dessalle from users-list stated:
[...] the code is not enforcing the field formats specification. For instance, I can set the dataset name of a Virtual file with lower case characters and a length longer than 26. [...]
And a...As Patrick Dessalle from users-list stated:
[...] the code is not enforcing the field formats specification. For instance, I can set the dataset name of a Virtual file with lower case characters and a length longer than 26. [...]
And as I reported to him:
[...] Fields contents are partially checked by the library.
Their format is not enforced but the data is stripped and filled with missing characters (it pads with space character or zeros depending on NUMERIC or ALPHA format)
Personally I think this is the best approach. Maybe we can add a log to WARN user of invalid data arriving at the library level.
The class I think we could add that warning is CommandExchangeBuffer, which would automatically proceed to all and every OFTP commands and fields. [...]
This is not considered as a bug, but may require an improvement.
So that's why we are adding a warn message for inconsistent field values.oftp-1.2.0.RC1https://gitlab.ow2.org/accord/accord/-/issues/48Indicate zero length field on unsigned EERPs2010-10-04T15:38:59ZBruno BorgesIndicate zero length field on unsigned EERPsWhen an unsigned EERP is going to be sent, the EERPSIGNL_FIELD should be indicated, with its value set to zero.
Patch attachedWhen an unsigned EERP is going to be sent, the EERPSIGNL_FIELD should be indicated, with its value set to zero.
Patch attachedoftp-1.2.0.RC1https://gitlab.ow2.org/accord/accord/-/issues/49Add missing answer reasons2010-10-06T19:57:05ZBruno BorgesAdd missing answer reasonsAdd missing fields of Answer Rerason, considering RFC 5024 page 55.
Add missing fields of Answer Rerason, considering RFC 5024 page 55.
oftp-1.2.0.RC1https://gitlab.ow2.org/accord/accord/-/issues/50Convert unknow code (out of spec) of NERP to 992010-10-06T20:06:44ZBruno BorgesConvert unknow code (out of spec) of NERP to 99Based on Patrick's observation:
[...] when parsing NERP NegativeReason. If the code is unknown (outside of the given list in the RFC), the current code throws an Exception. This patch does not fail but log a warn and set the reason to a...Based on Patrick's observation:
[...] when parsing NERP NegativeReason. If the code is unknown (outside of the given list in the RFC), the current code throws an Exception. This patch does not fail but log a warn and set the reason to an Unspecified Reason (99). I believe that we should not completely fail for such a small error from the remote side. Otherwise we never know that we got a NERP. [...]oftp-1.2.0.RC1https://gitlab.ow2.org/accord/accord/-/issues/51Set correct format for NERP fields2010-10-06T20:31:24ZBruno BorgesSet correct format for NERP fieldsIncorrect values for some NERP format (the last 4 were set to numeric while the RFC speaks of Binary)Incorrect values for some NERP format (the last 4 were set to numeric while the RFC speaks of Binary)oftp-1.2.0.RC1https://gitlab.ow2.org/accord/accord/-/issues/8CommandExchangeBufferTest#testParseNormalVer20StartFileBuffer() invalid buffe...2018-09-21T20:38:55ZRafael MarinsCommandExchangeBufferTest#testParseNormalVer20StartFileBuffer() invalid buffer were createdTests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.028 sec <<< FAILURE!
testParseNormalVer20StartFileBuffer(org.neociclo.odetteftp.protocol.CommandExchangeBufferTest) Time elapsed: 0.007 sec <<< FAILURE!
org.junit.Compar...Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.028 sec <<< FAILURE!
testParseNormalVer20StartFileBuffer(org.neociclo.odetteftp.protocol.CommandExchangeBufferTest) Time elapsed: 0.007 sec <<< FAILURE!
org.junit.ComparisonFailure: Invalid created buffer text. expected:<... U000000000[ 000000018000000000001700000000000000000030101N00 ]0> but was:<... U000000000[000000000000000000018000000000001700000000000000]0>
at org.junit.Assert.assertEquals(Assert.java:123)
at org.neociclo.odetteftp.protocol.CommandExchangeBufferTest.testParseNormalVer20StartFileBuffer(CommandExchangeBufferTest.java:212)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:592)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:592)
at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
https://gitlab.ow2.org/accord/accord/-/issues/12Name oftp api component as OSGi convention2018-09-21T20:38:55ZRafael MarinsName oftp api component as OSGi conventionBundle ID/Maven Artifact ID: org.neociclo.odetteftp.api
Maven Group ID: org.neociclo.odetteftpBundle ID/Maven Artifact ID: org.neociclo.odetteftp.api
Maven Group ID: org.neociclo.odetteftphttps://gitlab.ow2.org/accord/accord/-/issues/22Add test cases for the restart support implementation2018-09-21T20:38:55ZRafael MarinsAdd test cases for the restart support implementationhttps://gitlab.ow2.org/accord/accord/-/issues/26Change oftp api distribution to OW2 forge2018-09-21T20:38:55ZRafael MarinsChange oftp api distribution to OW2 forgehttps://gitlab.ow2.org/accord/accord/-/issues/28Use only SLF4J as logging framework2018-09-21T20:38:55ZRafael MarinsUse only SLF4J as logging frameworkResolve multiple logging frameworks in use. Identify the purpose and actions on using slf4j Markers.Resolve multiple logging frameworks in use. Identify the purpose and actions on using slf4j Markers.https://gitlab.ow2.org/accord/accord/-/issues/39Isolate the core OFTP api from the client code2010-08-11T20:46:17ZRafael MarinsIsolate the core OFTP api from the client codehttps://gitlab.ow2.org/accord/accord/-/issues/42Implement state machine in OFTP protocol relay2010-09-10T18:35:44ZRafael MarinsImplement state machine in OFTP protocol relayCheck possibility to avoid control of state in the OdetteFtpSession object.Check possibility to avoid control of state in the OdetteFtpSession object.https://gitlab.ow2.org/accord/accord/-/issues/64Provide network layer informational access in the OFTP session2011-03-01T14:53:02ZRafael MarinsProvide network layer informational access in the OFTP sessionIn the OFTP session some access to the network layer info is desired (i.e Listening IP of the server, listening port of the server, IP address of the client, If connection was made over TLS/SSL, TLS/SSL client certificate if any,...)
Th...In the OFTP session some access to the network layer info is desired (i.e Listening IP of the server, listening port of the server, IP address of the client, If connection was made over TLS/SSL, TLS/SSL client certificate if any,...)
Those informations can be useful to decide if client match security requirements and accept or refuse the OFTP session (SSL required for partners that don't send encrypted files for example), or doing some throttling (OFTP client connecting/reconnecting too fast, ...)
https://gitlab.ow2.org/accord/accord/-/issues/65Getting "Invalid Record count" and "Invalid byte count" as response when send...2012-06-08T05:03:17ZSyed RizwanGetting "Invalid Record count" and "Invalid byte count" as response when sending to OFTP receiverHi,
I am able to receive the file properly but when sending the file, the receiver responding with error "Invalid Record Count" or "Invalid Byte Count".
We are sending the file in fixed format with record length of 128.
Please suggest m...Hi,
I am able to receive the file properly but when sending the file, the receiver responding with error "Invalid Record Count" or "Invalid Byte Count".
We are sending the file in fixed format with record length of 128.
Please suggest me how to proceed.
Thanks in advance.
Regards,
Rizwan