Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • asm asm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • asm
  • asmasm
  • Issues
  • #317833
Closed
Open
Created May 26, 2018 by raphw@raphw

When ClassWriter copies constant pool of class reader, ClassWriter.COMPUTE_MAX does not consider changes in argument sizes

Consider the following code snippet given some class SampleClass { }:

ClassReader reader = new ClassReader(SampleClass.class.getName());
ClassWriter writer = new ClassWriter(reader, ClassWriter.COMPUTE_MAXS);
reader.accept(new ClassVisitor(Opcodes.ASM6, writer) {
  @Override
  public MethodVisitor visitMethod(int access, 
        String name, 
        String descriptor, 
        String signature, 
        String[] exceptions) {
    return super.visitMethod(access,
      name,
      "(Ljava/lang/Void;)V", // original: "()V"
      signature,
      exceptions);
  }
}, 0);

ClassReader result = new ClassReader(writer.toByteArray());
result.accept(new TraceClassVisitor(new PrintWriter(System.out)), 0);

The resulting class defines MAXLOCALS = 1 despite the constructor being widened to define one argument such that two slots are required for both the this argument and the added Void are not available what results in a verification error.

The problem does not occur if the class writer does not copy the constant pool.

Edited May 26, 2018 by raphw
Assignee
Assign to
Time tracking