asm merge requestshttps://gitlab.ow2.org/asm/asm/-/merge_requests2017-10-05T19:19:47Zhttps://gitlab.ow2.org/asm/asm/-/merge_requests/31Remove jbet and BCEL modified verifier tests2017-10-05T19:19:47ZEric BrunetonRemove jbet and BCEL modified verifier testsjbet is no longer available online and the BCEL modified verifier tests give many out of memory errors and are thus not meaningful.jbet is no longer available online and the BCEL modified verifier tests give many out of memory errors and are thus not meaningful.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/30Use assertEquals instead of hamcrest.core.text which is not present in Eclips...2017-10-04T18:25:21ZRemi ForaxUse assertEquals instead of hamcrest.core.text which is not present in Eclipse distribution of JUnit 4The JUnit jars included in Eclipse only contain the core Hamcrest matcher so the package hamcrest.core.text is not present.
Fix the test using assertEquals insteadThe JUnit jars included in Eclipse only contain the core Hamcrest matcher so the package hamcrest.core.text is not present.
Fix the test using assertEquals insteadEric BrunetonEric Brunetonhttps://gitlab.ow2.org/asm/asm/-/merge_requests/29data() return ArrayList instead of List and Enum.values() return a fresh arra...2017-10-04T18:24:51ZRemi Foraxdata() return ArrayList instead of List and Enum.values() return a fresh array at each call so it should be call onceFix classical Java mistakes i have missed during last code reviewFix classical Java mistakes i have missed during last code reviewEric BrunetonEric Brunetonhttps://gitlab.ow2.org/asm/asm/-/merge_requests/28Split the signature files per jar, to prepare for a new, Maven-like project l...2017-10-04T17:29:01ZEric BrunetonSplit the signature files per jar, to prepare for a new, Maven-like project layout.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/27Improve the code of the bnd plugin and add an 'in-place' option for the retro...2017-10-03T19:10:28ZEric BrunetonImprove the code of the bnd plugin and add an 'in-place' option for the retrofitter.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/26Delete GASMifier and the related code.2017-10-03T18:15:28ZEric BrunetonDelete GASMifier and the related code.GASMifierTest is broken and GASMifier is not maintained. We need a simpler and more direct way to test GeneratorAdapter than writing a full ASMifier-like for it, and testing it via this GASMifier class.GASMifierTest is broken and GASMifier is not maintained. We need a simpler and more direct way to test GeneratorAdapter than writing a full ASMifier-like for it, and testing it via this GASMifier class.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/25Refactor CodeSizeEvaluatorTest to use AsmTest.2017-10-02T18:55:30ZEric BrunetonRefactor CodeSizeEvaluatorTest to use AsmTest.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/24Refactor SAXAdapterTest to use AsmTest.2017-10-05T19:32:34ZEric BrunetonRefactor SAXAdapterTest to use AsmTest.Also fix bugs found with these new tests (some of them were also detected by the previous tests).Also fix bugs found with these new tests (some of them were also detected by the previous tests).Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/23Refactor the TraceClassAdapterTest to use AsmTest.2017-10-02T18:32:40ZEric BrunetonRefactor the TraceClassAdapterTest to use AsmTest.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/22Refactor CheckSignatureAdapterTest to use AsmTest.2017-10-02T19:00:54ZEric BrunetonRefactor CheckSignatureAdapterTest to use AsmTest.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/21Refactor the tree analysis tests to use AsmTest.2017-10-02T18:51:29ZEric BrunetonRefactor the tree analysis tests to use AsmTest.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/20Refactor ClassNodeTest to use AsmTest.2017-10-03T18:38:45ZEric BrunetonRefactor ClassNodeTest to use AsmTest.Also fix bugs found with these new tests, and improve the Javadoc related to modules.Also fix bugs found with these new tests, and improve the Javadoc related to modules.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/19Refactor CheckClassAdapterTest to use AsmTest.2017-10-02T18:43:07ZEric BrunetonRefactor CheckClassAdapterTest to use AsmTest.Also fix bugs in the Check*Adapter classes found with these new tests, and improve the error messages in MethodVisitor.Also fix bugs in the Check*Adapter classes found with these new tests, and improve the error messages in MethodVisitor.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/18Move the test methods from ClassWriterComputeFramesUnitTest to the precompile...2017-10-05T19:20:20ZEric BrunetonMove the test methods from ClassWriterComputeFramesUnitTest to the precompiled classes.Also move the large precompiled methods to their own classes, so that tests that don't support them (e.g. ASMifierTest because the generated code is too big) can still be tested on all instructions. Likewise, duplicate the jdk3.AllInstru...Also move the large precompiled methods to their own classes, so that tests that don't support them (e.g. ASMifierTest because the generated code is too big) can still be tested on all instructions. Likewise, duplicate the jdk3.AllInstructions methods in jdk5.AllInstructions, so that tests that don't support jsr/ret (e.g. COMPUTE_FRAMES) can still be tested on all instructions.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/17Refactor the ASMifier tests to use AsmTest.2018-03-11T21:50:38ZEric BrunetonRefactor the ASMifier tests to use AsmTest.The new tests fail with jdk3.* classes because of the handling of synthetic attribute vs flag. With a ClassReader->ClassWriter chain, ClassReader sets the ACC_SYNTHETIC_ATTRIBUTE pseudo access flag to know whether a Synthetic attribute w...The new tests fail with jdk3.* classes because of the handling of synthetic attribute vs flag. With a ClassReader->ClassWriter chain, ClassReader sets the ACC_SYNTHETIC_ATTRIBUTE pseudo access flag to know whether a Synthetic attribute was originally present. But this does not work with ASMifier (no ClassReader involved). To fix this I removed the ACC_SYNTHETIC_ATTRIBUTE pseudo access flag, and instead generate either the attribute or the access flag in ClassWriter, depending on the class version. This means a ClassReader->ClassWriter chain can change the attribute to an access flag, or vice versa, only with "strange" classes where the flag is used before 1.5, or the attribute is used after 1.5. I believe this does not introduce a regression for issue #314934, which was fixed with https://gitlab.ow2.org/asm/asm/commit/46b53a9ddae932d4813b1b3e95ed6ef3e1d6a238.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/16Refactor the ClassWriter tests to use AsmTest.2017-10-01T12:25:54ZEric BrunetonRefactor the ClassWriter tests to use AsmTest.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/15Refactor more tests to use AsmTest and JUnit 4.2017-10-01T12:13:44ZEric BrunetonRefactor more tests to use AsmTest and JUnit 4.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/14Refactor ClassReaderTest to use AsmTest and to test all constructors, accept ...2017-10-01T12:05:38ZEric BrunetonRefactor ClassReaderTest to use AsmTest and to test all constructors, accept flags and accessors.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/13Add a base class for parameterized tests.2017-09-30T13:43:36ZEric BrunetonAdd a base class for parameterized tests.This base class will be used to refactor the existing tests based on rt.jar.This base class will be used to refactor the existing tests based on rt.jar.Remi ForaxRemi Foraxhttps://gitlab.ow2.org/asm/asm/-/merge_requests/12Switch to the Google Java Style2017-09-30T13:43:44ZEric BrunetonSwitch to the Google Java StyleStyle Guide: https://google.github.io/styleguide/javaguide.html. The code will be reformatted with https://github.com/google/google-java-format in a following commit (without a merge request, as this would be too big and there is nothing...Style Guide: https://google.github.io/styleguide/javaguide.html. The code will be reformatted with https://github.com/google/google-java-format in a following commit (without a merge request, as this would be too big and there is nothing to tweak). After this, the code should always be formatted with this automatic tool before each commit.Remi ForaxRemi Forax