From a587c5bbc24342beef27a35fe6cf27af3c64b987 Mon Sep 17 00:00:00 2001 From: Lukas Rytz Date: Mon, 11 Jun 2018 12:39:21 +1000 Subject: [PATCH 1/2] Fix typos in JavaDoc --- .../objectweb/asm/tree/analysis/Interpreter.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/asm-analysis/src/main/java/org/objectweb/asm/tree/analysis/Interpreter.java b/asm-analysis/src/main/java/org/objectweb/asm/tree/analysis/Interpreter.java index c0a7cbdd8..4b567f57f 100644 --- a/asm-analysis/src/main/java/org/objectweb/asm/tree/analysis/Interpreter.java +++ b/asm-analysis/src/main/java/org/objectweb/asm/tree/analysis/Interpreter.java @@ -85,7 +85,7 @@ public abstract class Interpreter { * * @param insn the bytecode instruction to be interpreted. * @return the result of the interpretation of the given instruction. - * @throws AnalyzerException if an error occured during the interpretation. + * @throws AnalyzerException if an error occurred during the interpretation. */ public abstract V newOperation(AbstractInsnNode insn) throws AnalyzerException; @@ -100,7 +100,7 @@ public abstract class Interpreter { * @param value the value that must be moved by the instruction. * @return the result of the interpretation of the given instruction. The returned value must be * equal to the given value. - * @throws AnalyzerException if an error occured during the interpretation. + * @throws AnalyzerException if an error occurred during the interpretation. */ public abstract V copyOperation(AbstractInsnNode insn, V value) throws AnalyzerException; @@ -116,7 +116,7 @@ public abstract class Interpreter { * @param insn the bytecode instruction to be interpreted. * @param value the argument of the instruction to be interpreted. * @return the result of the interpretation of the given instruction. - * @throws AnalyzerException if an error occured during the interpretation. + * @throws AnalyzerException if an error occurred during the interpretation. */ public abstract V unaryOperation(AbstractInsnNode insn, V value) throws AnalyzerException; @@ -134,7 +134,7 @@ public abstract class Interpreter { * @param value1 the first argument of the instruction to be interpreted. * @param value2 the second argument of the instruction to be interpreted. * @return the result of the interpretation of the given instruction. - * @throws AnalyzerException if an error occured during the interpretation. + * @throws AnalyzerException if an error occurred during the interpretation. */ public abstract V binaryOperation(AbstractInsnNode insn, V value1, V value2) throws AnalyzerException; @@ -150,7 +150,7 @@ public abstract class Interpreter { * @param value2 the second argument of the instruction to be interpreted. * @param value3 the third argument of the instruction to be interpreted. * @return the result of the interpretation of the given instruction. - * @throws AnalyzerException if an error occured during the interpretation. + * @throws AnalyzerException if an error occurred during the interpretation. */ public abstract V ternaryOperation(AbstractInsnNode insn, V value1, V value2, V value3) throws AnalyzerException; @@ -165,7 +165,7 @@ public abstract class Interpreter { * @param insn the bytecode instruction to be interpreted. * @param values the arguments of the instruction to be interpreted. * @return the result of the interpretation of the given instruction. - * @throws AnalyzerException if an error occured during the interpretation. + * @throws AnalyzerException if an error occurred during the interpretation. */ public abstract V naryOperation(AbstractInsnNode insn, List values) throws AnalyzerException; @@ -178,7 +178,7 @@ public abstract class Interpreter { * @param insn the bytecode instruction to be interpreted. * @param value the argument of the instruction to be interpreted. * @param expected the expected return type of the analyzed method. - * @throws AnalyzerException if an error occured during the interpretation. + * @throws AnalyzerException if an error occurred during the interpretation. */ public abstract void returnOperation(AbstractInsnNode insn, V value, V expected) throws AnalyzerException; -- GitLab From 43655e34998fbaf7d65343a9cb53503c89e3e51e Mon Sep 17 00:00:00 2001 From: Lukas Rytz Date: Mon, 11 Jun 2018 12:40:50 +1000 Subject: [PATCH 2/2] Clarify the doc of MethodInsnNode.owner --- .../src/main/java/org/objectweb/asm/tree/MethodInsnNode.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/asm-tree/src/main/java/org/objectweb/asm/tree/MethodInsnNode.java b/asm-tree/src/main/java/org/objectweb/asm/tree/MethodInsnNode.java index afb1051de..dde55117a 100644 --- a/asm-tree/src/main/java/org/objectweb/asm/tree/MethodInsnNode.java +++ b/asm-tree/src/main/java/org/objectweb/asm/tree/MethodInsnNode.java @@ -43,6 +43,8 @@ public class MethodInsnNode extends AbstractInsnNode { /** * The internal name of the method's owner class (see {@link * org.objectweb.asm.Type#getInternalName()}). + * + * For methods of arrays, e.g., clone(), the array type descriptor. */ public String owner; -- GitLab