Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • asm asm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • asmasm
  • asmasm
  • Merge requests
  • !274

add ASM8_EXPERIMENTAL API + support of PermittedSubtypes attribute

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Remi Forax requested to merge asm8-permitted-subtypes into master Oct 04, 2019
  • Overview 29
  • Commits 8
  • Pipelines 6
  • Changes 93

As we discuss, this patch add ASM8_EXPERIMENTAL, i've slighly modified the code you send me because getResourceAsStream can return null and the InputStream as to be closed. BTW, PMD is currently configured to not allow an empty catch even if there is a comment in it, but here the right thing to do if we want still to be 1.5 compatible is to ignore the exception that can be raised by close().

Also because we don't run the tests with --enable-preview, i can not write a test to test that at least a roundtrip works

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: asm8-permitted-subtypes