Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • asm asm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • asmasm
  • asmasm
  • Merge requests
  • !279

Add an abstract MemberVisitor class to be able to reduce code duplication in...

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Eric Bruneton requested to merge add-member-visitor-class into master Oct 20, 2019
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 7

Add an abstract MemberVisitor class to be able to reduce code duplication in ClassReader. Not sure if the class and/or its methods must be public.

Results of 3 benchmark runs with this change:

Benchmark Mode Cnt Score Error Units AdapterBenchmark.read_asm7_1 thrpt 30 623,892 ± 1,506 ops/s AdapterBenchmark.read_asmCurrent thrpt 30 621,629 ± 1,835 ops/s

Benchmark Mode Cnt Score Error Units AdapterBenchmark.read_asm7_1 thrpt 30 624,589 ± 1,260 ops/s AdapterBenchmark.read_asmCurrent thrpt 30 622,971 ± 2,541 ops/s

Benchmark Mode Cnt Score Error Units AdapterBenchmark.read_asm7_1 thrpt 30 623,515 ± 1,680 ops/s AdapterBenchmark.read_asmCurrent thrpt 30 622,151 ± 1,619 ops/s

and without it:

Benchmark Mode Cnt Score Error Units AdapterBenchmark.read_asm7_1 thrpt 30 624,141 ± 1,511 ops/s AdapterBenchmark.read_asmCurrent thrpt 30 625,117 ± 1,653 ops/s

Benchmark Mode Cnt Score Error Units AdapterBenchmark.read_asm7_1 thrpt 30 607,326 ± 1,285 ops/s AdapterBenchmark.read_asmCurrent thrpt 30 621,902 ± 1,259 ops/s

Benchmark Mode Cnt Score Error Units AdapterBenchmark.read_asm7_1 thrpt 30 623,548 ± 1,490 ops/s AdapterBenchmark.read_asmCurrent thrpt 30 621,814 ± 1,579 ops/s

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: add-member-visitor-class