Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • asm asm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • asmasm
  • asmasm
  • Merge requests
  • !4

Fix the handling of inner classes with EXPAND_ASM_INSNS.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eric Bruneton requested to merge 317792-fix-inner-class-handling-with-expand-asm-insns into master Sep 07, 2017
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Resetting the inner class data structures so that they are rebuilt when revisiting the code with a ClassReader does not work, due to the code in visitInnerClass to avoid duplicate entries in this table (based on state stored in the constant pool entries, which are not reset). In fact, thanks to this code to avoid duplicate entries, we can skip resetting the inner class data structures here, and be assured that they will not change when revisiting the class with a ClassReader.

Closes #317792 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 317792-fix-inner-class-handling-with-expand-asm-insns