Commit 1099cd3f authored by Remi Forax's avatar Remi Forax

second round of review fixes

delegate is now read-only for users,
use TODO when ASM8_EPERIMENTAL will become ASM8
parent 320c8fed
Pipeline #6769 passed with stage
in 9 minutes and 55 seconds
......@@ -53,7 +53,8 @@ public class RecordComponentRemapper extends RecordComponentVisitor {
*/
public RecordComponentRemapper(
final RecordComponentVisitor recordComponentVisitor, final Remapper remapper) {
this(/* latest api = */ Opcodes.ASM8_EXPERIMENTAL, recordComponentVisitor, remapper);
// TODO: add 'latest api =' comment when no longer experimental.
this(Opcodes.ASM8_EXPERIMENTAL, recordComponentVisitor, remapper);
}
/**
......
......@@ -72,7 +72,8 @@ public final class TraceRecordComponentVisitor extends RecordComponentVisitor {
@Deprecated
public TraceRecordComponentVisitor(
final RecordComponentVisitor recordComponentVisitor, final Printer printer) {
super(/* latest api = */ Opcodes.ASM8_EXPERIMENTAL, recordComponentVisitor);
// TODO: add 'latest api =' comment when no longer experimental.
super(Opcodes.ASM8_EXPERIMENTAL, recordComponentVisitor);
this.printerExperimental = printer;
}
......
......@@ -47,7 +47,7 @@ public abstract class RecordComponentVisitor {
/**
* The record visitor to which this visitor must delegate method calls. May be {@literal null}.
*/
protected RecordComponentVisitor delegate;
/*package-private*/ RecordComponentVisitor delegate;
/**
* Constructs a new {@link RecordComponentVisitor}.
......@@ -87,6 +87,17 @@ public abstract class RecordComponentVisitor {
this.delegate = recordComponentVisitor;
}
/**
* The record visitor to which this visitor must delegate method calls. May be {@literal null}.
*
* @return the record visitor to which this visitor must delegate method calls or {@literal null}.
* @deprecated this API is experimental.
*/
@Deprecated
public RecordComponentVisitor getDelegateExperimental() {
return delegate;
}
/**
* Visits an annotation of the record component.
*
......
......@@ -103,7 +103,8 @@ final class RecordComponentWriter extends RecordComponentVisitor {
final String name,
final String descriptor,
final String signature) {
super(/* latest api = */ Opcodes.ASM8_EXPERIMENTAL);
// TODO: add 'latest api =' comment when no longer experimental.
super(Opcodes.ASM8_EXPERIMENTAL);
this.symbolTable = symbolTable;
this.accessFlags = accessFlags;
this.nameIndex = symbolTable.addConstantUtf8(name);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment