Commit 895bc520 authored by Remi Forax's avatar Remi Forax

fix latest nits from the code review

parent f903330e
Pipeline #6737 passed with stage
in 9 minutes and 52 seconds
......@@ -305,8 +305,7 @@ public abstract class AsmTest {
* with {@code @MethodSource("allClassesAndLatestApi")} will be executed on all the precompiled
* classes, with the latest api.
*
* @return all the possible (precompiledClass, ASM8_EXPERIMENTAL) pairs, for all the precompiled
* classes.
* @return all the possible (precompiledClass, ASM8) pairs, for all the precompiled classes.
*/
public static Stream<Arguments> allClassesAndLatestApi() {
return classesAndApis(Api.ASM8);
......
......@@ -130,6 +130,8 @@ public class ClassNode extends ClassVisitor {
* <b>Experimental, use at your own risk. This method will be renamed when it becomes stable, this
* will break existing code using it</b>. The internal names of the permitted subtypes of this
* class. May be {@literal null}.
*
* @deprecated this API is experimental.
*/
@Deprecated public List<String> permittedSubtypesExperimental;
......
......@@ -88,16 +88,15 @@ public class PrinterTest {
assertEquals(UNSUPPORTED_OPERATION_MESSAGE, exception.getMessage());
}
/* Experimental feature for now
@Test
public void testVisitPermittedSubtype_unsupportedByDefault() {
Printer printer = new EmptyPrinter(Opcodes.ASM8_EXPERIMENTAL);
Printer printer = new EmptyPrinter(/* latest */ Opcodes.ASM8_EXPERIMENTAL);
Executable visitPermittedSubtype = () -> printer.visitPermittedSubtype(null);
Executable visitPermittedSubtype = () -> printer.visitPermittedSubtypeExperimental(null);
Exception exception = assertThrows(UnsupportedOperationException.class, visitPermittedSubtype);
assertEquals(UNSUPPORTED_OPERATION_MESSAGE, exception.getMessage());
}*/
}
@Test
public void testVisitMainClass_unsupportedByDefault() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment