Commit e1cc902d authored by Eric Bruneton's avatar Eric Bruneton

Improve the Javadoc (small nits).

parent 39a4a7d7
Pipeline #524 passed with stage
in 10 minutes and 39 seconds
......@@ -43,7 +43,7 @@ public class AnalyzerException extends Exception {
public final transient AbstractInsnNode node;
/**
* Creates a new {@link AnalyzerException}.
* Constructs a new {@link AnalyzerException}.
*
* @param insn the bytecode instruction where the analysis failed.
* @param message the reason why the analysis failed.
......@@ -54,7 +54,7 @@ public class AnalyzerException extends Exception {
}
/**
* Creates a new {@link AnalyzerException}.
* Constructs a new {@link AnalyzerException}.
*
* @param insn the bytecode instruction where the analysis failed.
* @param message the reason why the analysis failed.
......@@ -67,7 +67,7 @@ public class AnalyzerException extends Exception {
}
/**
* Creates a new {@link AnalyzerException}.
* Constructs a new {@link AnalyzerException}.
*
* @param insn the bytecode instruction where the analysis failed.
* @param message the reason why the analysis failed.
......
......@@ -56,7 +56,7 @@ public class BasicInterpreter extends Interpreter<BasicValue> implements Opcodes
public static final Type NULL_TYPE = Type.getObjectType("null");
/**
* Creates a new {@link BasicInterpreter} for the latest ASM API version. <i>Subclasses must not
* Constructs a new {@link BasicInterpreter} for the latest ASM API version. <i>Subclasses must not
* use this constructor</i>. Instead, they must use the {@link #BasicInterpreter(int)} version.
*/
public BasicInterpreter() {
......@@ -67,7 +67,7 @@ public class BasicInterpreter extends Interpreter<BasicValue> implements Opcodes
}
/**
* Creates a new {@link BasicInterpreter}.
* Constructs a new {@link BasicInterpreter}.
*
* @param api the ASM API version supported by this interpreter. Must be one of {@link
* org.objectweb.asm.Opcodes#ASM4}, {@link org.objectweb.asm.Opcodes#ASM5} or {@link
......
......@@ -63,7 +63,7 @@ public class BasicValue implements Value {
private final Type type;
/**
* Creates a new {@link BasicValue} of the given type.
* Constructs a new {@link BasicValue} of the given type.
*
* @param type the value type.
*/
......
......@@ -44,7 +44,7 @@ import org.objectweb.asm.tree.MethodInsnNode;
public class BasicVerifier extends BasicInterpreter {
/**
* Creates a new {@link BasicVerifier} for the latest ASM API version. <i>Subclasses must not use
* Constructs a new {@link BasicVerifier} for the latest ASM API version. <i>Subclasses must not use
* this constructor</i>. Instead, they must use the {@link #BasicVerifier(int)} version.
*/
public BasicVerifier() {
......@@ -55,7 +55,7 @@ public class BasicVerifier extends BasicInterpreter {
}
/**
* Creates a new {@link BasicVerifier}.
* Constructs a new {@link BasicVerifier}.
*
* @param api the ASM API version supported by this interpreter. Must be one of {@link
* org.objectweb.asm.Opcodes#ASM4}, {@link org.objectweb.asm.Opcodes#ASM5} or {@link
......
......@@ -52,7 +52,7 @@ public abstract class Interpreter<V extends Value> {
protected final int api;
/**
* Creates a new {@link Interpreter}.
* Constructs a new {@link Interpreter}.
*
* @param api the ASM API version supported by this interpreter. Must be one of {@link
* org.objectweb.asm.Opcodes#ASM4}, {@link org.objectweb.asm.Opcodes#ASM5} or {@link
......
......@@ -54,14 +54,14 @@ final class SmallSet<T> extends AbstractSet<T> {
// Constructors
// -----------------------------------------------------------------------------------------------
/** Creates an empty set. */
/** Constructs an empty set. */
SmallSet() {
this.element1 = null;
this.element2 = null;
}
/**
* Creates a set with exactly one element.
* Constructs a set with exactly one element.
*
* @param element the unique set element.
*/
......@@ -71,7 +71,7 @@ final class SmallSet<T> extends AbstractSet<T> {
}
/**
* Creates a new {@link SmallSet}.
* Constructs a new {@link SmallSet}.
*
* @param element1 see {@link #element1}.
* @param element2 see {@link #element2}.
......
......@@ -47,7 +47,7 @@ import org.objectweb.asm.tree.MethodInsnNode;
public class SourceInterpreter extends Interpreter<SourceValue> implements Opcodes {
/**
* Creates a new {@link SourceInterpreter} for the latest ASM API version. <i>Subclasses must not
* Constructs a new {@link SourceInterpreter} for the latest ASM API version. <i>Subclasses must not
* use this constructor</i>. Instead, they must use the {@link #SourceInterpreter(int)} version.
*/
public SourceInterpreter() {
......@@ -58,7 +58,7 @@ public class SourceInterpreter extends Interpreter<SourceValue> implements Opcod
}
/**
* Creates a new {@link SourceInterpreter}.
* Constructs a new {@link SourceInterpreter}.
*
* @param api the ASM API version supported by this interpreter. Must be one of {@link
* org.objectweb.asm.Opcodes#ASM4}, {@link org.objectweb.asm.Opcodes#ASM5} or {@link
......
......@@ -60,7 +60,7 @@ public class SourceValue implements Value {
public final Set<AbstractInsnNode> insns;
/**
* Creates a new {@link SourceValue}.
* Constructs a new {@link SourceValue}.
*
* @param size the size of this value, in 32 bits words. This size is 1 for byte, boolean, char,
* short, int, float, object and array types, and 2 for long and double.
......@@ -70,7 +70,7 @@ public class SourceValue implements Value {
}
/**
* Creates a new {@link SourceValue}.
* Constructs a new {@link SourceValue}.
*
* @param size the size of this value, in 32 bits words. This size is 1 for byte, boolean, char,
* short, int, float, object and array types, and 2 for long and double.
......@@ -82,7 +82,7 @@ public class SourceValue implements Value {
}
/**
* Creates a new {@link SourceValue}.
* Constructs a new {@link SourceValue}.
*
* @param size the size of this value, in 32 bits words. This size is 1 for byte, boolean, char,
* short, int, float, object and array types, and 2 for long and double.
......
......@@ -53,7 +53,7 @@ final class Subroutine {
final List<JumpInsnNode> callers;
/**
* Creates a new {@link Subroutine}.
* Constructs a new {@link Subroutine}.
*
* @param start the start of this subroutine.
* @param maxLocals the local variables that are read or written by this subroutine.
......@@ -67,7 +67,7 @@ final class Subroutine {
}
/**
* Creates a copy of the given {@link Subroutine}.
* Constructs a copy of the given {@link Subroutine}.
*
* @param subroutine the subroutine to copy.
*/
......
......@@ -74,7 +74,7 @@ public abstract class AdviceAdapter extends GeneratorAdapter implements Opcodes
private Map<Label, List<Object>> branches;
/**
* Creates a new {@link AdviceAdapter}.
* Constructs a new {@link AdviceAdapter}.
*
* @param api the ASM API version implemented by this visitor. Must be one of {@link
* Opcodes#ASM4}, {@link Opcodes#ASM5} or {@link Opcodes#ASM6}.
......
......@@ -98,7 +98,7 @@ public class AnalyzerAdapter extends MethodVisitor {
private String owner;
/**
* Creates a new {@link AnalyzerAdapter}. <i>Subclasses must not use this constructor</i>.
* Constructs a new {@link AnalyzerAdapter}. <i>Subclasses must not use this constructor</i>.
* Instead, they must use the {@link #AnalyzerAdapter(int, String, int, String, String,
* MethodVisitor)} version.
*
......@@ -122,7 +122,7 @@ public class AnalyzerAdapter extends MethodVisitor {
}
/**
* Creates a new {@link AnalyzerAdapter}.
* Constructs a new {@link AnalyzerAdapter}.
*
* @param api the ASM API version implemented by this visitor. Must be one of {@link
* Opcodes#ASM4}, {@link Opcodes#ASM5} or {@link Opcodes#ASM6}.
......
......@@ -183,7 +183,7 @@ public class GeneratorAdapter extends LocalVariablesSorter {
private final List<Type> localTypes = new ArrayList<Type>();
/**
* Creates a new {@link GeneratorAdapter}. <i>Subclasses must not use this constructor</i>.
* Constructs a new {@link GeneratorAdapter}. <i>Subclasses must not use this constructor</i>.
* Instead, they must use the {@link #GeneratorAdapter(int, MethodVisitor, int, String, String)}
* version.
*
......@@ -202,7 +202,7 @@ public class GeneratorAdapter extends LocalVariablesSorter {
}
/**
* Creates a new {@link GeneratorAdapter}.
* Constructs a new {@link GeneratorAdapter}.
*
* @param api the ASM API version implemented by this visitor. Must be one of {@link
* Opcodes#ASM4}, {@link Opcodes#ASM5} or {@link Opcodes#ASM6}.
......@@ -224,7 +224,7 @@ public class GeneratorAdapter extends LocalVariablesSorter {
}
/**
* Creates a new {@link GeneratorAdapter}. <i>Subclasses must not use this constructor</i>.
* Constructs a new {@link GeneratorAdapter}. <i>Subclasses must not use this constructor</i>.
* Instead, they must use the {@link #GeneratorAdapter(int, MethodVisitor, int, String, String)}
* version.
*
......@@ -237,7 +237,7 @@ public class GeneratorAdapter extends LocalVariablesSorter {
}
/**
* Creates a new {@link GeneratorAdapter}. <i>Subclasses must not use this constructor</i>.
* Constructs a new {@link GeneratorAdapter}. <i>Subclasses must not use this constructor</i>.
* Instead, they must use the {@link #GeneratorAdapter(int, MethodVisitor, int, String, String)}
* version.
*
......@@ -878,7 +878,7 @@ public class GeneratorAdapter extends LocalVariablesSorter {
// ------------------------------------------------------------------------
/**
* Creates a new {@link Label}.
* Constructs a new {@link Label}.
*
* @return a new {@link Label}.
*/
......
......@@ -44,7 +44,7 @@ public class InstructionAdapter extends MethodVisitor {
public static final Type OBJECT_TYPE = Type.getType("Ljava/lang/Object;");
/**
* Creates a new {@link InstructionAdapter}. <i>Subclasses must not use this constructor</i>.
* Constructs a new {@link InstructionAdapter}. <i>Subclasses must not use this constructor</i>.
* Instead, they must use the {@link #InstructionAdapter(int, MethodVisitor)} version.
*
* @param mv the method visitor to which this adapter delegates calls.
......@@ -58,7 +58,7 @@ public class InstructionAdapter extends MethodVisitor {
}
/**
* Creates a new {@link InstructionAdapter}.
* Constructs a new {@link InstructionAdapter}.
*
* @param api the ASM API version implemented by this visitor. Must be one of {@link
* Opcodes#ASM4}, {@link Opcodes#ASM5} or {@link Opcodes#ASM6}.
......
......@@ -80,7 +80,7 @@ public class JSRInlinerAdapter extends MethodNode implements Opcodes {
final BitSet dualCitizens = new BitSet();
/**
* Creates a new JSRInliner. <i>Subclasses must not use this constructor</i>. Instead, they must
* Constructs a new JSRInliner. <i>Subclasses must not use this constructor</i>. Instead, they must
* use the {@link #JSRInlinerAdapter(int, MethodVisitor, int, String, String, String, String[])}
* version.
*
......@@ -109,7 +109,7 @@ public class JSRInlinerAdapter extends MethodNode implements Opcodes {
}
/**
* Creates a new JSRInliner.
* Constructs a new JSRInliner.
*
* @param api the ASM API version implemented by this visitor. Must be one of {@link
* Opcodes#ASM4}, {@link Opcodes#ASM5} or {@link Opcodes#ASM6}.
......
......@@ -66,7 +66,7 @@ public class LocalVariablesSorter extends MethodVisitor {
protected int nextLocal;
/**
* Creates a new {@link LocalVariablesSorter}. <i>Subclasses must not use this constructor</i>.
* Constructs a new {@link LocalVariablesSorter}. <i>Subclasses must not use this constructor</i>.
* Instead, they must use the {@link #LocalVariablesSorter(int, int, String, MethodVisitor)}
* version.
*
......@@ -83,7 +83,7 @@ public class LocalVariablesSorter extends MethodVisitor {
}
/**
* Creates a new {@link LocalVariablesSorter}.
* Constructs a new {@link LocalVariablesSorter}.
*
* @param api the ASM API version implemented by this visitor. Must be one of {@link
* Opcodes#ASM4}, {@link Opcodes#ASM5} or {@link Opcodes#ASM6}.
......@@ -246,7 +246,7 @@ public class LocalVariablesSorter extends MethodVisitor {
// -------------
/**
* Creates a new local variable of the given type.
* Constructs a new local variable of the given type.
*
* @param type the type of the local variable to be created.
* @return the identifier of the newly created local variable.
......
......@@ -64,7 +64,7 @@ public class Method {
}
/**
* Creates a new {@link Method}.
* Constructs a new {@link Method}.
*
* @param name the method's name.
* @param desc the method's descriptor.
......@@ -75,7 +75,7 @@ public class Method {
}
/**
* Creates a new {@link Method}.
* Constructs a new {@link Method}.
*
* @param name the method's name.
* @param returnType the method's return type.
......
......@@ -48,7 +48,7 @@ public final class ModuleHashesAttribute extends Attribute {
public List<byte[]> hashes;
/**
* Creates an attribute with a hashing algorithm, a list of module names, and a list of the same
* Constructs an attribute with a hashing algorithm, a list of module names, and a list of the same
* length of hashes.
*
* @param algorithm the hashing algorithm name.
......@@ -64,7 +64,7 @@ public final class ModuleHashesAttribute extends Attribute {
}
/**
* Creates an empty attribute that can be used as prototype to be passed as argument of the method
* Constructs an empty attribute that can be used as prototype to be passed as argument of the method
* {@link ClassReader#accept(org.objectweb.asm.ClassVisitor, Attribute[], int)}.
*/
public ModuleHashesAttribute() {
......
......@@ -64,7 +64,7 @@ public final class ModuleResolutionAttribute extends Attribute {
public int resolution;
/**
* Creates an attribute with a resolution state value.
* Constructs an attribute with a resolution state value.
*
* @param resolution the resolution state among {@link #RESOLUTION_WARN_DEPRECATED}, {@link
* #RESOLUTION_WARN_DEPRECATED_FOR_REMOVAL}, and {@link #RESOLUTION_WARN_INCUBATING}.
......@@ -75,7 +75,7 @@ public final class ModuleResolutionAttribute extends Attribute {
}
/**
* Creates an empty attribute that can be used as prototype to be passed as argument of the method
* Constructs an empty attribute that can be used as prototype to be passed as argument of the method
* {@link ClassReader#accept(org.objectweb.asm.ClassVisitor, Attribute[], int)}.
*/
public ModuleResolutionAttribute() {
......
......@@ -43,7 +43,7 @@ public final class ModuleTargetAttribute extends Attribute {
public String platform;
/**
* Creates an attribute with a platform name.
* Constructs an attribute with a platform name.
*
* @param platform the platform name on which the module can run.
*/
......@@ -53,7 +53,7 @@ public final class ModuleTargetAttribute extends Attribute {
}
/**
* Creates an empty attribute that can be used as prototype to be passed as argument of the method
* Constructs an empty attribute that can be used as prototype to be passed as argument of the method
* {@link ClassReader#accept(org.objectweb.asm.ClassVisitor, Attribute[], int)}.
*/
public ModuleTargetAttribute() {
......
......@@ -166,7 +166,7 @@ public abstract class Remapper {
}
/**
* Creates a new remapper for signatures.
* Constructs a new remapper for signatures.
*
* @param v the SignatureVisitor the remapper must delegate to.
* @return the newly created remapper.
......@@ -178,7 +178,7 @@ public abstract class Remapper {
}
/**
* Creates a new remapper for signatures.
* Constructs a new remapper for signatures.
*
* @param v the SignatureVisitor the remapper must delegate to.
* @return the newly created remapper.
......
......@@ -138,7 +138,7 @@ public class SerialVersionUIDAdder extends ClassVisitor {
private Collection<Item> svuidMethods;
/**
* Creates a new {@link SerialVersionUIDAdder}. <i>Subclasses must not use this constructor</i>.
* Constructs a new {@link SerialVersionUIDAdder}. <i>Subclasses must not use this constructor</i>.
* Instead, they must use the {@link #SerialVersionUIDAdder(int, ClassVisitor)} version.
*
* @param cv a {@link ClassVisitor} to which this visitor will delegate calls.
......@@ -152,7 +152,7 @@ public class SerialVersionUIDAdder extends ClassVisitor {
}
/**
* Creates a new {@link SerialVersionUIDAdder}.
* Constructs a new {@link SerialVersionUIDAdder}.
*
* @param api the ASM API version implemented by this visitor. Must be one of {@link
* Opcodes#ASM4}, {@link Opcodes#ASM5} or {@link Opcodes#ASM6}.
......
......@@ -118,7 +118,7 @@ class ClassDump {
private final String dump;
/**
* Creates a new ClassDump instance. The input byte array is parsed and converted to a string
* Constructs a new ClassDump instance. The input byte array is parsed and converted to a string
* representation by this constructor. The result can then be obtained with {@link #toString}.
*
* @param bytecode the content of a class file.
......@@ -254,7 +254,7 @@ class ClassDump {
private final ClassContext classContext;
/**
* Creates a CpInfo for an item without references to other items.
* Constructs a CpInfo for an item without references to other items.
*
* @param dump the dump of this item.
*/
......@@ -264,7 +264,7 @@ class ClassDump {
}
/**
* Creates a CpInfo for an item with references to other items.
* Constructs a CpInfo for an item with references to other items.
*
* @param classContext a context to lookup constant pool items from their index.
*/
......
......@@ -85,7 +85,7 @@ public class ASMifierTest extends AsmTest {
*/
@ParameterizedTest
@MethodSource(ALL_CLASSES_AND_LATEST_API)
public void testAsmifyCompileAndExecute(PrecompiledClass classParameter, Api apiParameter)
public void testAsmifyCompileAndExecute(final PrecompiledClass classParameter, final Api apiParameter)
throws Exception {
byte[] classFile = classParameter.getBytes();
if (classFile.length > Short.MAX_VALUE) return;
......
......@@ -77,8 +77,8 @@ public class CheckClassAdapterTest extends AsmTest implements Opcodes {
@Test
public void testVerifyValidClass() throws Exception {
ClassReader cr = new ClassReader(getClass().getName());
CheckClassAdapter.verify(cr, true, new PrintWriter(new StringWriter()));
ClassReader classReader = new ClassReader(getClass().getName());
CheckClassAdapter.verify(classReader, true, new PrintWriter(new StringWriter()));
}
@Test
......@@ -93,8 +93,8 @@ public class CheckClassAdapterTest extends AsmTest implements Opcodes {
mv.visitMaxs(1, 31);
mv.visitEnd();
cw.visitEnd();
ClassReader cr = new ClassReader(cw.toByteArray());
CheckClassAdapter.verify(cr, true, new PrintWriter(new StringWriter()));
ClassReader classReader = new ClassReader(cw.toByteArray());
CheckClassAdapter.verify(classReader, true, new PrintWriter(new StringWriter()));
}
@Test
......@@ -371,14 +371,14 @@ public class CheckClassAdapterTest extends AsmTest implements Opcodes {
@Test
public void testIllegalDebugLabelUse() throws IOException {
ClassReader cr = new ClassReader("java.lang.Object");
ClassWriter cw = new ClassWriter(cr, ClassWriter.COMPUTE_MAXS);
ClassReader classReader = new ClassReader("java.lang.Object");
ClassWriter cw = new ClassWriter(classReader, ClassWriter.COMPUTE_MAXS);
ClassVisitor cv =
new ClassVisitor(Opcodes.ASM5, cw) {
@Override
public MethodVisitor visitMethod(
int access, String name, String desc, String signature, String[] exceptions) {
final MethodVisitor next = cv.visitMethod(access, name, desc, signature, exceptions);
final int access, final String name, final String descriptor, final String signature, final String[] exceptions) {
final MethodVisitor next = cv.visitMethod(access, name, descriptor, signature, exceptions);
if (next == null) {
return next;
}
......@@ -386,7 +386,7 @@ public class CheckClassAdapterTest extends AsmTest implements Opcodes {
private Label entryLabel = null;
@Override
public void visitLabel(Label label) {
public void visitLabel(final Label label) {
if (entryLabel == null) {
entryLabel = label;
}
......@@ -394,7 +394,7 @@ public class CheckClassAdapterTest extends AsmTest implements Opcodes {
}
@Override
public void visitMaxs(int maxStack, int maxLocals) {
public void visitMaxs(final int maxStack, final int maxLocals) {
Label unwindhandler = new Label();
mv.visitLabel(unwindhandler);
mv.visitInsn(Opcodes.ATHROW); // rethrow
......@@ -404,7 +404,7 @@ public class CheckClassAdapterTest extends AsmTest implements Opcodes {
};
}
};
assertThrows(Exception.class, () -> cr.accept(cv, ClassReader.EXPAND_FRAMES));
assertThrows(Exception.class, () -> classReader.accept(cv, ClassReader.EXPAND_FRAMES));
}
@Test
......@@ -706,7 +706,7 @@ public class CheckClassAdapterTest extends AsmTest implements Opcodes {
@ParameterizedTest
@MethodSource(ALL_CLASSES_AND_ALL_APIS)
public void testCheckClassAdapter_classUnchanged(
PrecompiledClass classParameter, Api apiParameter) {
final PrecompiledClass classParameter, final Api apiParameter) {
byte[] classFile = classParameter.getBytes();
ClassReader classReader = new ClassReader(classFile);
ClassWriter classWriter = new ClassWriter(0);
......@@ -722,7 +722,7 @@ public class CheckClassAdapterTest extends AsmTest implements Opcodes {
/** Tests that {@link CheckClassAdapter.verify()} succeeds on all precompiled classes. */
@ParameterizedTest
@MethodSource(ALL_CLASSES_AND_ALL_APIS)
public void testCheckClassAdapter_verify(PrecompiledClass classParameter, Api apiParameter) {
public void testCheckClassAdapter_verify(final PrecompiledClass classParameter, final Api apiParameter) {
ClassReader classReader = new ClassReader(classParameter.getBytes());
StringWriter stringWriter = new StringWriter();
PrintWriter printWriter = new PrintWriter(stringWriter);
......
......@@ -161,7 +161,7 @@ public class CheckSignatureAdapterTest extends AsmTest {
assertThrows(Exception.class, () -> sv.visitEnd());
}
private void setup(int type) {
private void setup(final int type) {
sv = new CheckSignatureAdapter(type, null);
}
......@@ -171,18 +171,18 @@ public class CheckSignatureAdapterTest extends AsmTest {
*/
@ParameterizedTest
@MethodSource(ALL_CLASSES_AND_LATEST_API)
public void test(PrecompiledClass classParameter, Api apiParameter) throws Exception {
public void test(final PrecompiledClass classParameter, final Api apiParameter) throws Exception {
ClassReader classReader = new ClassReader(classParameter.getBytes());
classReader.accept(
new ClassVisitor(apiParameter.value()) {
@Override
public void visit(
int version,
int access,
String name,
String signature,
String superName,
String[] interfaces) {
final int version,
final int access,
final String name,
final String signature,
final String superName,
final String[] interfaces) {
if (signature != null) {
SignatureReader signatureReader = new SignatureReader(signature);
SignatureWriter signatureWriter = new SignatureWriter();
......@@ -195,7 +195,7 @@ public class CheckSignatureAdapterTest extends AsmTest {
@Override
public FieldVisitor visitField(
int access, String name, String desc, String signature, Object value) {
final int access, final String name, final String descriptor, final String signature, final Object value) {
if (signature != null) {
SignatureReader signatureReader = new SignatureReader(signature);
SignatureWriter signatureWriter = new SignatureWriter();
......@@ -208,7 +208,7 @@ public class CheckSignatureAdapterTest extends AsmTest {
@Override
public MethodVisitor visitMethod(
int access, String name, String desc, String signature, String[] exceptions) {
final int access, final String name, final String descriptor, final String signature, final String[] exceptions) {
if (signature != null) {
SignatureReader signatureReader = new SignatureReader(signature);
SignatureWriter signatureWriter = new SignatureWriter();
......
......@@ -34,8 +34,6 @@ import org.objectweb.asm.ByteVector;
import org.objectweb.asm.ClassReader;
import org.objectweb.asm.ClassWriter;
import org.objectweb.asm.Label;
import org.objectweb.asm.util.ASMifiable;
import org.objectweb.asm.util.Textifiable;
/**
* A non standard code attribute used for testing purposes.
......@@ -60,7 +58,7 @@ public class CodeComment extends Attribute implements ASMifiable, Textifiable {
@Override
protected Attribute read(
final ClassReader cr,
final ClassReader classReader,
final int off,
final int len,
final char[] buf,
......@@ -80,12 +78,6 @@ public class CodeComment extends Attribute implements ASMifiable, Textifiable {
return new ByteVector();
}
@Override
protected Label[] getLabels() {
super.getLabels();
return new Label[] {new Label()};
}
public void asmify(
final StringBuffer buf, final String varName, final Map<Label, String> labelNames) {
buf.append("Attribute ")
......
......@@ -34,8 +34,6 @@ import org.objectweb.asm.ByteVector;
import org.objectweb.asm.ClassReader;
import org.objectweb.asm.ClassWriter;
import org.objectweb.asm.Label;
import org.objectweb.asm.util.ASMifiable;
import org.objectweb.asm.util.Textifiable;
/**
* A non standard attribute used for testing purposes.
......@@ -55,7 +53,7 @@ public class Comment extends Attribute implements ASMifiable, Textifiable {
@Override
protected Attribute read(
final ClassReader cr,
final ClassReader classReader,
final int off,
final int len,
final char[] buf,
......
......@@ -73,7 +73,7 @@ public class TraceClassAdapterTest extends AsmTest {
*/
@ParameterizedTest
@MethodSource(ALL_CLASSES_AND_LATEST_API)
public void testTrace(PrecompiledClass classParameter, Api apiParameter) {
public void testTrace(final PrecompiledClass classParameter, final Api apiParameter) {
byte[] classFile = classParameter.getBytes();
ClassReader classReader = new ClassReader(classFile);
ClassWriter classWriter = new ClassWriter(0);
......
......@@ -93,7 +93,7 @@ public class TraceSignatureVisitorTest {
@ParameterizedTest
@MethodSource("testArguments")
public void testSignature(TestData data) {
public void testSignature(final TestData data) {
TraceSignatureVisitor d = new TraceSignatureVisitor(data.access);
SignatureReader r = new SignatureReader(data.signature);
......@@ -114,6 +114,8 @@ public class TraceSignatureVisitorTest {
+ (d.getExceptions() != null ? d.getExceptions() : "");
assertEquals(data.declaration, fullMethodDeclaration);
break;
default:
throw new IllegalArgumentException();
}
}
......
......@@ -584,7 +584,7 @@ public class Processor {
private int ident = 0;
/**
* Creates <code>SAXWriter</code>.
* Constructs <code>SAXWriter</code>.
*
* @param w writer
* @param optimizeEmptyElements if set to <code>true</code>, short XML syntax will be used for
......
......@@ -79,15 +79,14 @@ public abstract class ClassVisitor {
* and the major version in the 16 least significant bits.
* @param access the class's access flags (see {@link Opcodes}). This parameter also indicates if
* the class is deprecated.
* @param name the internal name of the class (see {@link Type#getInternalName()
* getInternalName}).
* @param name the internal name of the class (see {@link Type#getInternalName()}).
* @param signature the signature of this class. May be <tt>null</tt> if the class is not a
* generic one, and does not extend or implement generic classes or interfaces.
* @param superName the internal of name of the super class (see {@link Type#getInternalName()
* getInternalName}). For interfaces, the super class is {@link Object}. May be <tt>null</tt>,
* but only for the {@link Object} class.
* @param superName the internal of name of the super class (see {@link Type#getInternalName()}).
* For interfaces, the super class is {@link Object}. May be <tt>null</tt>, but only for the
* {@link Object} class.
* @param interfaces the i