Inconsistent behaviour of ClassReader and ClassVisitor under Java 11 in version 6.2.1
in asm 6.2.1 ClassVisitor method visitNestMemberExperimental checks that api version is not less than Opcodes.ASM7_EXPERIMENTAL = 17235968
/** @deprecated */ @Deprecated public void visitNestMemberExperimental(String nestMember) { if (this.api < 17235968) { throw new UnsupportedOperationException(); } else { if (this.cv != null) { this.cv.visitNestMemberExperimental(nestMember); }
}
}
but the calling method ClassReader.accept(groovyjarjarasm.asm.ClassVisitor, groovyjarjarasm.asm.Attribute[], int) does not make any checks on it.
if (nestMembersOffset != 0) {
fieldsCount = this.readUnsignedShort(nestMembersOffset);
for(methodsCount = nestMembersOffset + 2; fieldsCount-- > 0; methodsCount += 2) {
classVisitor.visitNestMemberExperimental(this.readClass(methodsCount, charBuffer));
}
}
It leads to issues like https://issues.apache.org/jira/browse/GROOVY-8727.
Example stacktrace:
java.lang.UnsupportedOperationException
at groovyjarjarasm.asm.ClassVisitor.visitNestMemberExperimental(ClassVisitor.java:248)
at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:651)
at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:391)
at org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
at org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:254)
at org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:192)
at org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:172)
at org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:128)
at org.codehaus.groovy.control.ResolveVisitor.resolveToOuter(ResolveVisitor.java:744)
at org.codehaus.groovy.control.ResolveVisitor.resolve(ResolveVisitor.java:394)
at org.codehaus.groovy.control.ResolveVisitor.resolveFromDefaultImports(ResolveVisitor.java:522)
at org.codehaus.groovy.control.ResolveVisitor.resolve(ResolveVisitor.java:392)
at org.codehaus.groovy.control.ResolveVisitor.resolve(ResolveVisitor.java:355)
at org.codehaus.groovy.control.ResolveVisitor.resolveOrFail(ResolveVisitor.java:339)
at org.codehaus.groovy.control.ResolveVisitor.resolveOrFail(ResolveVisitor.java:351)
at org.codehaus.groovy.control.ResolveVisitor.transformConstructorCallExpression(ResolveVisitor.java:1141)
at org.codehaus.groovy.control.ResolveVisitor.transform(ResolveVisitor.java:774)
at org.codehaus.groovy.control.ResolveVisitor.transformMethodCallExpression(ResolveVisitor.java:1156)
at org.codehaus.groovy.control.ResolveVisitor.transform(ResolveVisitor.java:770)
at org.codehaus.groovy.control.ResolveVisitor.transformMethodCallExpression(ResolveVisitor.java:1156)
at org.codehaus.groovy.control.ResolveVisitor.transform(ResolveVisitor.java:770)
at org.codehaus.groovy.control.ResolveVisitor.transformBinaryExpression(ResolveVisitor.java:1048)
at org.codehaus.groovy.control.ResolveVisitor.transform(ResolveVisitor.java:768)
at org.codehaus.groovy.control.ResolveVisitor.transformBinaryExpression(ResolveVisitor.java:1109)
at org.codehaus.groovy.control.ResolveVisitor.transform(ResolveVisitor.java:768)
at org.codehaus.groovy.ast.ClassCodeExpressionTransformer.visitExpressionStatement(ClassCodeExpressionTransformer.java:144)
at org.codehaus.groovy.ast.stmt.ExpressionStatement.visit(ExpressionStatement.java:42)
at org.codehaus.groovy.ast.CodeVisitorSupport.visitBlockStatement(CodeVisitorSupport.java:88)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitBlockStatement(ClassCodeVisitorSupport.java:106)
at org.codehaus.groovy.control.ResolveVisitor.visitBlockStatement(ResolveVisitor.java:1430)
at org.codehaus.groovy.ast.stmt.BlockStatement.visit(BlockStatement.java:71)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitClassCodeContainer(ClassCodeVisitorSupport.java:110)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitConstructorOrMethod(ClassCodeVisitorSupport.java:121)
at org.codehaus.groovy.ast.ClassCodeExpressionTransformer.visitConstructorOrMethod(ClassCodeExpressionTransformer.java:55)
at org.codehaus.groovy.control.ResolveVisitor.visitConstructorOrMethod(ResolveVisitor.java:249)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitMethod(ClassCodeVisitorSupport.java:132)
at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1103)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitClass(ClassCodeVisitorSupport.java:54)
at org.codehaus.groovy.control.ResolveVisitor.visitClass(ResolveVisitor.java:1375)
at org.codehaus.groovy.control.ResolveVisitor.startResolving(ResolveVisitor.java:222)
at org.codehaus.groovy.control.CompilationUnit$13.call(CompilationUnit.java:691)
at org.codehaus.groovy.control.CompilationUnit.applyToSourceUnits(CompilationUnit.java:968)
at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:633)
at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:582)
at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:354)
at groovy.lang.GroovyClassLoader.access$300(GroovyClassLoader.java:87)
at groovy.lang.GroovyClassLoader$5.provide(GroovyClassLoader.java:323)
at groovy.lang.GroovyClassLoader$5.provide(GroovyClassLoader.java:320)
at org.codehaus.groovy.runtime.memoize.ConcurrentCommonCache.getAndPut(ConcurrentCommonCache.java:147)
at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:318)