Commit 3eee7580 authored by Committed by Adrien
fix(http): always return non 200 code in case of error (#13)
Returning 200 code prevented the caller to detect that an error occured. Now return 400 when file argument is empty and 500 for non specific exception. In addition, as we return text in response on error, set the response content type to text/plain More tests have been added to the controller. This implies refactoring - inject windows and mack sign collaborator - extract new collaborator for all file based operations Tests now use mockk instead of mockito as mockito cannot mock final class and mockk is designed for Kotlin Remove duplicated code in the Rest Controller between 'sign' and 'build and sign Mac installer'
Showing with 253 additions and 120 deletions