fix(search fields): redraw table with StyledString when search field is updated (#2529)

updated

* The filter change isn't detected automatically anymore on macos big
sur /=
* Fix some selection change issues

[STUDIO-3712](https://bonitasoft.atlassian.net/browse/STUDIO-3712)

bundles/plugins/org.bonitasoft.studio.businessobject/src/org/bonitasoft/studio/businessobject/editor/editor/ui/control/attribute/AttributeEditionControl.java

@@ -147,6 +147,12 @@ public class AttributeEditionControl extends Composite {
                         .filter(field -> !field.getName().toLowerCase().contains(search))
                         .forEach(fieldToFilter::add);
                 viewer.refresh();
+
+                // Necessary since the MacOS Big Sur update -> Seems that table with StyledCellLabelProvider aren't redraw automatically 
+                // TODO Hopefully this could be removed on the futur (current date: 23/11/2020)
+                if (Objects.equals(Platform.getOS(), Platform.OS_MACOSX)) {
+                    viewer.getControl().redraw();
+                }
             });
         });
     }

bundles/plugins/org.bonitasoft.studio.businessobject/src/org/bonitasoft/studio/businessobject/editor/editor/ui/control/constraint/ConstraintEditionControl.java

@@ -46,6 +46,7 @@ import org.eclipse.core.databinding.observable.list.IObservableList;
 import org.eclipse.core.databinding.observable.set.WritableSet;
 import org.eclipse.core.databinding.observable.value.ComputedValue;
 import org.eclipse.core.databinding.observable.value.IObservableValue;
+import org.eclipse.core.runtime.Platform;
 import org.eclipse.emf.databinding.EMFObservables;
 import org.eclipse.jface.databinding.swt.typed.WidgetProperties;
 import org.eclipse.jface.databinding.viewers.ObservableListContentProvider;
@@ -294,6 +295,12 @@ public class ConstraintEditionControl {
                         .filter(constraint -> !constraint.getName().toLowerCase().contains(search))
                         .forEach(constraintsToFilter::add);
                 constraintViewer.refresh();
+
+                // Necessary since the MacOS Big Sur update -> Seems that table with StyledCellLabelProvider aren't redraw automatically 
+                // TODO Hopefully this could be removed on the futur (current date: 23/11/2020)
+                if (Objects.equals(Platform.getOS(), Platform.OS_MACOSX)) {
+                    constraintViewer.getControl().redraw();
+                }
             });
         });
     }

bundles/plugins/org.bonitasoft.studio.businessobject/src/org/bonitasoft/studio/businessobject/editor/editor/ui/control/index/IndexControl.java

@@ -45,6 +45,7 @@ import org.eclipse.core.databinding.observable.Realm;
 import org.eclipse.core.databinding.observable.list.IObservableList;
 import org.eclipse.core.databinding.observable.value.ComputedValue;
 import org.eclipse.core.databinding.observable.value.IObservableValue;
+import org.eclipse.core.runtime.Platform;
 import org.eclipse.emf.databinding.EMFObservables;
 import org.eclipse.jface.databinding.swt.typed.WidgetProperties;
 import org.eclipse.jface.databinding.viewers.ObservableListContentProvider;
@@ -148,6 +149,12 @@ public class IndexControl {
                         .filter(index -> !index.getName().toLowerCase().contains(search))
                         .forEach(indexesToFilter::add);
                 indexViewer.refresh();
+
+                // Necessary since the MacOS Big Sur update -> Seems that table with StyledCellLabelProvider aren't redraw automatically 
+                // TODO Hopefully this could be removed on the futur (current date: 23/11/2020)
+                if (Objects.equals(Platform.getOS(), Platform.OS_MACOSX)) {
+                    indexViewer.getControl().redraw();
+                }
             });
         });
     }

bundles/plugins/org.bonitasoft.studio.businessobject/src/org/bonitasoft/studio/businessobject/editor/editor/ui/control/index/IndexEditionControl.java

@@ -36,6 +36,7 @@ import org.eclipse.core.databinding.observable.Realm;
 import org.eclipse.core.databinding.observable.list.IObservableList;
 import org.eclipse.core.databinding.observable.list.WritableList;
 import org.eclipse.core.databinding.observable.value.IObservableValue;
+import org.eclipse.core.runtime.Platform;
 import org.eclipse.emf.databinding.EMFObservables;
 import org.eclipse.jface.databinding.viewers.ObservableListContentProvider;
 import org.eclipse.jface.databinding.viewers.ViewersObservables;
@@ -121,6 +122,15 @@ public class IndexEditionControl extends Composite {
         createIndexedAttributesTableViewer(viewersComposite);
 
         indexedFieldsObservable.addChangeListener(e -> availableAttributesTableViewer.refresh());
+
+        selectedIndexObservable.addValueChangeListener(e -> {
+            // Necessary since the MacOS Big Sur update -> Seems that table with StyledCellLabelProvider aren't redraw automatically 
+            // TODO Hopefully this could be removed on the futur (current date: 23/11/2020)
+            if (Objects.equals(Platform.getOS(), Platform.OS_MACOSX)) {
+                availableAttributesTableViewer.getControl().redraw();
+                indexedAttributesTableViewer.getControl().redraw();
+            }
+        });
     }
 
     private void bindIndexedFieldObservableLists(DataBindingContext ctx, IObservableList<Field> actualsFieldsObservable) {

bundles/plugins/org.bonitasoft.studio.businessobject/src/org/bonitasoft/studio/businessobject/editor/editor/ui/control/query/QueryDetailsControl.java

@@ -49,6 +49,7 @@ import org.eclipse.core.databinding.DataBindingContext;
 import org.eclipse.core.databinding.observable.Realm;
 import org.eclipse.core.databinding.observable.list.IObservableList;
 import org.eclipse.core.databinding.observable.value.IObservableValue;
+import org.eclipse.core.runtime.Platform;
 import org.eclipse.emf.databinding.EMFObservables;
 import org.eclipse.jface.databinding.swt.typed.WidgetProperties;
 import org.eclipse.jface.databinding.viewers.ObservableListContentProvider;
@@ -299,6 +300,12 @@ public class QueryDetailsControl extends Composite {
                         .filter(param -> !param.getName().toLowerCase().contains(search))
                         .forEach(parametersToFilter::add);
                 parametersTableViewer.refresh();
+
+                // Necessary since the MacOS Big Sur update -> Seems that table with StyledCellLabelProvider aren't redraw automatically 
+                // TODO Hopefully this could be removed on the futur (current date: 23/11/2020)
+                if (Objects.equals(Platform.getOS(), Platform.OS_MACOSX)) {
+                    parametersTableViewer.getControl().redraw();
+                }
             });
         });
     }
@@ -375,6 +382,14 @@ public class QueryDetailsControl extends Composite {
         parametersMultipleSelectionObservable = ViewerProperties.multipleSelection(QueryParameter.class)
                 .observe(parametersTableViewer);
         parametersTableViewer.setInput(selectedQueryParameterObservableList);
+
+        querySelectedObservable.addValueChangeListener(e -> {
+            // Necessary since the MacOS Big Sur update -> Seems that table with StyledCellLabelProvider aren't redraw automatically 
+            // TODO Hopefully this could be removed on the futur (current date: 23/11/2020)
+            if (Objects.equals(Platform.getOS(), Platform.OS_MACOSX)) {
+                parametersTableViewer.getControl().redraw();
+            }
+        });
     }
 
     private void createDescriptionColumn(TableViewer viewer) {