fix(UI):User is redirected to the reset password page when the login request...

fix(UI):User is redirected to the reset password page when the login request receive a 500 error (#11110)

* Fix autocomplete that doesn't appear

* Fix wizard layout

* Fix redirection

* Improve test

* Fix autocomplete that doesn't appear

* Fix wizard layout

* fix(readme): remove useless carriage return

* Fix redirection

* Improve test

* Revert some changes

* Improve reability

Co-authored-by: Kevin Duret <kduret@centreon.com>

www/front_src/src/Login/index.test.tsx

@@ -147,6 +147,19 @@ const mockPostLoginPasswordExpired = (): void => {
   });
 };
 
+const labelError = 'This is an error from the server';
+
+const mockPostLoginServerError = (): void => {
+  mockedAxios.post.mockRejectedValue({
+    response: {
+      data: {
+        message: labelError,
+      },
+      status: 500,
+    },
+  });
+};
+
 const labelInvalidCredentials = 'Invalid credentials';
 
 describe('Login Page', () => {
@@ -316,4 +329,21 @@ describe('Login Page', () => {
 
     expect(window.location.href).toBe('http://localhost/reset-password');
   });
+
+  it('stays on the login page when the login request returns a 500 error', async () => {
+    mockPostLoginServerError();
+    renderLoginPage();
+
+    userEvent.type(screen.getByLabelText(labelAlias), 'admin');
+    userEvent.type(screen.getByLabelText(labelPassword), 'centreon');
+
+    userEvent.click(screen.getByLabelText(labelConnect));
+
+    await waitFor(() => {
+      expect(screen.getByText(labelError)).toBeInTheDocument();
+    });
+
+    expect(window.location.href).not.toBe('http://localhost/reset-password');
+    expect(screen.getByLabelText(labelAlias)).toBeInTheDocument();
+  });
 });

www/front_src/src/Login/useLogin.ts

@@ -107,20 +107,18 @@ const useLogin = (): UseLoginState => {
         error,
       ) as RedirectAPI;
 
-      if (isUserNotAllowed && not(passwordIsExpired)) {
-        setSubmitting(false);
-        showErrorMessage(
-          path(['response', 'data', 'message'], error) as string,
-        );
+      if (isUserNotAllowed && passwordIsExpired) {
+        setPasswordResetInformations({
+          alias,
+        });
+        navigate(routeMap.resetPassword);
+        showWarningMessage(t(labelPasswordHasExpired));
 
         return;
       }
 
-      setPasswordResetInformations({
-        alias,
-      });
-      navigate(routeMap.resetPassword);
-      showWarningMessage(t(labelPasswordHasExpired));
+      setSubmitting(false);
+      showErrorMessage(path(['response', 'data', 'message'], error) as string);
     },
     [],
   );