Do not use CommonGLPI on classes that do not require it

inc/api/api.class.php

@@ -41,7 +41,6 @@ use APIClient;
 use Auth;
 use Change;
 use CommonDevice;
-use CommonGLPI;
 use CommonITILObject;
 use Config;
 use Contract;
@@ -65,7 +64,7 @@ use Ticket;
 use Toolbox;
 use User;
 
-abstract class API extends CommonGLPI {
+abstract class API {
 
    // permit writing to $_SESSION
    protected $session_write = false;

inc/auth.class.php

@@ -39,9 +39,7 @@ if (!defined('GLPI_ROOT')) {
 /**
  *  Identification class used to login
  */
-class Auth extends CommonGLPI {
-
-   static $rightname = 'config';
+class Auth {
 
    /** @var array Array of errors */
    private $errors = [];

inc/dashboard/filter.class.php

@@ -32,7 +32,6 @@
 
 namespace Glpi\Dashboard;
 
-use CommonGLPI;
 use Group;
 use Html;
 use ITILCategory;
@@ -50,7 +49,7 @@ if (!defined('GLPI_ROOT')) {
 /**
  * Filter class
 **/
-class Filter extends CommonGLPI {
+class Filter {
 
    /**
     * Return all available filters

inc/dashboard/grid.class.php

@@ -32,7 +32,6 @@
 
 namespace Glpi\Dashboard;
 
-use CommonGLPI;
 use DBConnection;
 use Dropdown;
 use Entity;
@@ -50,7 +49,7 @@ if (!defined('GLPI_ROOT')) {
    die("Sorry. You can't access this file directly");
 }
 
-class Grid extends CommonGLPI {
+class Grid {
    protected $cell_margin     = 6;
    protected $grid_cols       = 26;
    protected $grid_rows       = 24;

inc/dashboard/provider.class.php

@@ -34,7 +34,6 @@ namespace Glpi\Dashboard;
 
 use Change;
 use CommonDBTM;
-use CommonGLPI;
 use CommonITILActor;
 use CommonITILObject;
 use CommonITILValidation;
@@ -60,7 +59,7 @@ if (!defined('GLPI_ROOT')) {
 /**
  * Provider class
 **/
-class Provider extends CommonGLPI {
+class Provider {
 
 
    /**

inc/dashboard/widget.class.php

@@ -32,7 +32,6 @@
 
 namespace Glpi\Dashboard;
 
-use CommonGLPI;
 use Html;
 use Mexitek\PHPColors\Color;
 use Michelf\MarkdownExtra;
@@ -48,7 +47,7 @@ if (!defined('GLPI_ROOT')) {
 /**
  * Widget class
 **/
-class Widget extends CommonGLPI {
+class Widget {
    static $animation_duration = 1000; // in millseconds
 
 

inc/marketplace/controller.class.php

@@ -47,6 +47,9 @@ use Session;
 use Toolbox;
 use wapmorgan\UnifiedArchive\UnifiedArchive;
 
+/**
+ * Nota: `CommonGLPI` is required here to be able to provide a displayable name for its crons and notifications.
+ */
 class Controller extends CommonGLPI {
    protected $plugin_key = "";
 

inc/update.class.php

@@ -37,7 +37,7 @@ if (!defined('GLPI_ROOT')) {
 /**
  *  Update class
 **/
-class Update extends CommonGLPI {
+class Update {
    private $args = [];
    private $DB;
    private $migration;