Commit 01ba3b6e authored by Xavier Guimard's avatar Xavier Guimard

Fix handler namespace

parent fd88d685
......@@ -66,7 +66,7 @@ sub logLevelInit {
# adapt server signature
sub serverSignatureInit {
my $class = shift;
require Lemonldap::NG::Handler;
require Lemonldap::NG::Handler::Main;
my $version = $Lemonldap::NG::Handler::VERSION;
$class->setServerSignature("Lemonldap::NG/$version");
}
......
  • This fix breaks the server signature, we now have:

    [Fri Feb 01 08:56:07.163613 2019] [mpm_event:notice] [pid 4750:tid 139960947907520] AH00489: Apache/2.4.27 (Ubuntu) Lemonldap::NG/ mod_fcgid/2.3.9 mod_perl/2.0.10 Perl/v5.26.0 configured -- resuming normal operation

    We need to load the $VERSION of Lemonldap::NG::Handler main module (see #1618 (closed)). Maybe we could just remove the STDERR message in this module?

    print STDERR
    "Use the appropriate handler. For Apache, use Lemonldap::NG::Handler::ApacheMP2";

    Either we can push this message trough standard logger, either we remove it, as the change is documented in upgrade notes.

    Edited by Clément OUDOT
  • Ok to remove the print STDERR and revert this commit?

  • Thanks, I'll do it

  • mentioned in commit 372073e1

    Toggle commit list
  • mentioned in commit b79c7112

    Toggle commit list
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment