Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • lemonldap-ng lemonldap-ng
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 311
    • Issues 311
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LemonLDAP NGLemonLDAP NG
  • lemonldap-nglemonldap-ng
  • Issues
  • #2159
Closed
Open
Issue created Apr 20, 2020 by Maxime Besson@maxbes🔧Maintainer

Single session module configuration

Concerned version

Version: 2.0.7

Summary

Single session options are highly confusing, and most of them are broken.

Parameter Name in manager French name in manager Description in wiki Actual effect
singleIP One IP only by user One session per (IP,user) pair Allow only one session per IP ❌ Remove all sessions not matching the current IP on login for the current user
singleSession One session only by user One session per user Allow only one session per user ✅ Remove all previous sessions on login
singleUserByIP One user by IP address One user per IP address Allow only one user per IP ❌ Error 500, removes all sessions matching the current IP on login for all users
singleSessionUserByIP One session by IP address One session per IP address Allow only one session per user on an IP ❌ Not implemented

Suggested fixes

  • Rectify label and documentation for singleIP, it's correct in English, but not in French
  • Fix singleUserByIP, does anyone need it? It's been broken since 2.0, maybe longer. There are heavy privacy implications about displaying information about other users connecting from the same IP.
  • Remove singleSessionUserByIP, I have no idea what it's supposed to do that the other options don't already do. And it's not implemented.
  • We need more unit tests.
Edited Apr 20, 2020 by Maxime Besson
Assignee
Assign to
Time tracking