Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • lemonldap-ng lemonldap-ng
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 313
    • Issues 313
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LemonLDAP NGLemonLDAP NG
  • lemonldap-nglemonldap-ng
  • Issues
  • #2543
Closed
Open
Issue created Jun 14, 2021 by Maxime Besson@maxbes🔧Maintainer

[security:low] 2FA bypass with sfOnlyUpgrade and totp2fDisplayExistingSecret

Concerned version

Version: 2.0.11

Summary

  • Configure "Use 2FA for session upgrade"
  • Configure TOTP with "Display existing secret" enabled
  • Steal a user's password and login with it
  • Go to 2FA manager, click TOTP
  • Scan the user's existing TOTP to your own device, and profit. on backends

Possible fixes

Either

  • Remove the ability to display existing 2FA secrets Or
  • Protect existing secret from being displayed when current authentication level is too low

Depending on #2541 (closed)

Edited Jun 24, 2021 by Clément OUDOT
Assignee
Assign to
Time tracking