Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • lemonldap-ng lemonldap-ng
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 315
    • Issues 315
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LemonLDAP NGLemonLDAP NG
  • lemonldap-nglemonldap-ng
  • Merge requests
  • !144

Allow user to set their login when registering

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Louis Chemineau requested to merge artonge/lemonldap-ng:master into master May 07, 2020
  • Overview 5
  • Commits 21
  • Pipelines 14
  • Changes 7

Hi,

I added the possibility for a registering user to set its login.

Changes:

  • Introduce registerDisplayLoginInput config variable to toggle the visibility of the login input.
  • Use registerDisplayLoginInput to create a template variable DISPLAY_LOGIN_INPUT
  • Create a login input in register.tpl
  • Add the login param to the registerInfo object in Register.pm
  • Use the provided login instead of calling computeLogin
  • Make isLoginUsed method a public method in SAML and AD
  • Add a isLoginUsed method to DEMO to make it compliant with the new API requirement
  • Add default values for the variables in Attributes.pm

Extra changes:

  • Introduce loginControl config variables to validate the login and validate the login in the registration flow in Register.pm
  • Introduce registerLdapObjectClasses config variable to customize the objectClass in userCreation in LDAP.pm and AD.pm
  • Introduce registerTransformNames to prevent first and last name transformation in userCreation

Needed changes (I would need guidance):

  • Create a PE_LOGINALREADYEXISTS variable in Register.pm and a correct error message
  • Add inputs in manager
  • Write tests
Edited Sep 09, 2020 by Yadd
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master