Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • lemonldap-ng lemonldap-ng
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 326
    • Issues 326
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LemonLDAP NGLemonLDAP NG
  • lemonldap-nglemonldap-ng
  • Merge requests
  • !332

Draft: Changes for the still in progress Fedora review

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Xavier Bachelot requested to merge xavierb/lemonldap-ng:fedora_review into v2.0 Mar 09, 2023
  • Overview 0
  • Commits 14
  • Pipelines 1
  • Changes 1

Here's the current state of the changes needed for the Fedora package review [1]. This is still considered a draft as the final review is still pending. I'll update this PR if new items need to be added, although any preliminary feedback would be indeed very appreciated

List of changes:

  • Improve Summary:
  • Drop updates-alternatives from %%post
  • Split long line
  • Drop useless comments
  • Add provides for bundled javascript libraries and adapt License tag accordingly
  • Add provides for bundled font and adapt License tag accordingly
  • Make use of %%lm_sharedir instead of plain path
  • Add BR: for uglify-js
  • Move examples to %%_docdir
  • Fix perms on %%lm_vardir/captcha and %%_rundir/llng-fastcgi-server
  • Drop redundant dirs creation and perms change
  • Conditionalize test that needs network access
  • Disable lasso for F38+

[1] https://bugzilla.redhat.com/show_bug.cgi?id=2050682

Edited Mar 09, 2023 by Xavier Bachelot
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fedora_review