Configuration change causes redirection loop on portal
Hi guys,
In commit 26b80873 , a new portal access filtering feature was introduced, along with the relevant configuration file update.
However, I see a few issues with this
First: the configuration was rolled back in commit 8bc9e509 , I'm not sure exactly why, but in the current state, the debian trunk packages from Gitlab are broken and cause a redirection loop when browsing the portal as any access to the portal will be sent to /lmError/403 , which will loop to itself because it's denied as well.
Second: even if we revert the initial configuration file to its initial state, people who have already several configuration updates will NOT have the new locationRule for the portal, and will encounter the redirection loop. This means a broken portal after doing an update.
I think the default LLNG behaviour should be to authorize all access to the portal by default to preserve compatibility, and allow the admin to add its own access rule to deny part of it.
And last: I'm surprised noone noticed this breaking change before? Perhaps the unit tests should use a config file that is closer to the config file provided in packages. Or perhaps instead of a specific e2e-tests/lmConf-1.json
config file for local testing, we should use the "_examples" config file and a few overrides if needed?