Yes true, my mistake.
The rename should many be mentioned in the changelog. A User that actually is using encrypt (old way), will have to change his config, and should get this information!
I should have remembered this earlier, because this already was the case with the renaming of encrypt to encrypt1...
This is a great idea and will help the users, thanks for reviewing and solving the conflicts. I did a fast review through your changes, everything looks great!
Thanks for your time! Looks great!
I have to learn perl again to check if this does what it should^^ So give this a second look, and it's ready to merge!
I applied the patch against 2.0.15 and tested it on a real instance.
He is my summery about what has been tested successfully by Unit tests:
On a real instance:
What's not included:
$y$
prefix did not work in MariaDB and is not respected by the written algorithms. However, it should be easy to add this if needed, if the selected Database is supporting this.$id$rounds=yyy$salt$encrypted
rounds describes e.g. the number of SHA iterations. This was not respected or tested. But could possibly still work for login, but will not be respected for changing passwords.encrypth
functionality in Postgres.And of course
Many thanks for considering merging this patch
I have a draft here, it passed all unit tests including the commented out ones. It could be nice to get them back into the test file, but the dbiDynamicHashNewPasswordScheme would need to be changed after my tests complete. For being able to test the ssha512 afterwards.
It's up to you against what this should be merged to, please just edit the merge request.
Please tell me if there is something that needs to be changed or if I missed something.
Thank you for helping
Master Q (54c6f5b5) at 01 Oct 16:17
Added unix password scheme to DBI.
Master Q (54c6f5b5) at 01 Oct 16:16
Added unix password scheme to DBI.
Master Q (85359fa6) at 01 Oct 15:55
updated help text
Master Q (fbd58526) at 01 Oct 14:22
back to 45 and removed test
Master Q (8f08f94d) at 01 Oct 14:02
changed amount of tests from 45 to 46
Master Q (b613862e) at 01 Oct 13:51
testing print
Master Q (dde8a06c) at 01 Oct 13:42
testing error
Master Q (4662a932) at 01 Oct 13:40
Converting the salt to as needed
Master Q (765be651) at 01 Oct 13:32
Lets see if we see warnings
Master Q (c1de24b8) at 01 Oct 13:25
Lets see if we see warnings
Master Q (95d655ab) at 01 Oct 11:21
commended extra tests
Master Q (096053ed) at 01 Oct 11:13
fixed wrong variable: hash->dbhash