Limit PE_* imports (#595)

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/AD.pm

@@ -5,7 +5,8 @@ package Lemonldap::NG::Portal::Auth::AD;
 
 use strict;
 use Mouse;
-use Lemonldap::NG::Portal::Main::Constants;
+use Lemonldap::NG::Portal::Main::Constants
+  qw(PE_OK PE_PP_PASSWORD_EXPIRED PE_PP_CHANGE_AFTER_RESET);
 
 our $VERSION = '2.0.0';
 

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/Apache.pm

@@ -2,13 +2,14 @@ package Lemonldap::NG::Portal::Auth::Apache;
 
 use strict;
 use Mouse;
-use Lemonldap::NG::Portal::Main::Constants;
+use Lemonldap::NG::Portal::Main::Constants qw(PE_ERROR PE_OK);
 
 our $VERSION = '0.1';
 
 extends 'Lemonldap::NG::Portal::Auth::Base';
 
 sub init {
+    PE_ERROR;
     1;
 }
 

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/DBI.pm

@@ -2,7 +2,7 @@ package Lemonldap::NG::Portal::Auth::DBI;
 
 use strict;
 use Mouse;
-use Lemonldap::NG::Portal::Main::Constants;
+use Lemonldap::NG::Portal::Main::Constants qw(PE_OK PE_BADCREDENTIALS);
 
 our $VERSION = '2.0.0';
 

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/Demo.pm

@@ -7,7 +7,7 @@ package Lemonldap::NG::Portal::Auth::Demo;
 
 use strict;
 use Mouse;
-use Lemonldap::NG::Portal::Main::Constants;
+use Lemonldap::NG::Portal::Main::Constants qw(PE_OK PE_BADCREDENTIALS);
 
 extends qw(Lemonldap::NG::Portal::Auth::_WebForm);
 

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/LDAP.pm

@@ -2,7 +2,8 @@ package Lemonldap::NG::Portal::Auth::LDAP;
 
 use strict;
 use Mouse;
-use Lemonldap::NG::Portal::Main::Constants;
+use Lemonldap::NG::Portal::Main::Constants
+  qw(PE_OK PE_LDAPCONNECTFAILED PE_PP_CHANGE_AFTER_RESET PE_PP_PASSWORD_EXPIRED);
 
 our $VERSION = '2.0.0';
 

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/_WebForm.pm

@@ -7,7 +7,8 @@ package Lemonldap::NG::Portal::Auth::_WebForm;
 
 use strict;
 use Mouse;
-use Lemonldap::NG::Portal::Main::Constants;
+use Lemonldap::NG::Portal::Main::Constants
+  qw(PE_OK PE_FIRSTACCESS PE_FORMEMPTY PE_PASSWORDFORMEMPTY PE_CAPTCHAEMPTY PE_CAPTCHAERROR);
 
 our $VERSION = '2.0.0';
 

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Main.pm

@@ -4,7 +4,7 @@ use strict;
 use Mouse;
 
 use Lemonldap::NG::Common::Conf::Constants;
-use Lemonldap::NG::Portal::Main::Constants;
+use Lemonldap::NG::Portal::Main::Constants ':all';
 use Lemonldap::NG::Portal::Main::Request;
 use Lemonldap::NG::Portal::Main::Plugins;
 use Lemonldap::NG::Portal::Main::Init;

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Main/Constants.pm

@@ -122,7 +122,7 @@ use constant {
 };
 
 # EXPORTER PARAMETERS
-our @EXPORT = qw( PE_IMG_NOK PE_IMG_OK PE_INFO PE_REDIRECT PE_DONE PE_OK
+our @EXPORT_OK = qw( PE_IMG_NOK PE_IMG_OK PE_INFO PE_REDIRECT PE_DONE PE_OK
   PE_SESSIONEXPIRED PE_FORMEMPTY PE_WRONGMANAGERACCOUNT PE_USERNOTFOUND
   PE_BADCREDENTIALS PE_LDAPCONNECTFAILED PE_LDAPERROR PE_APACHESESSIONERROR
   PE_FIRSTACCESS PE_BADCERTIFICATE PE_PP_ACCOUNT_LOCKED PE_PP_PASSWORD_EXPIRED
@@ -153,8 +153,8 @@ our @EXPORT = qw( PE_IMG_NOK PE_IMG_OK PE_INFO PE_REDIRECT PE_DONE PE_OK
   PM_OIDC_SCOPE_PHONE PM_OIDC_SCOPE_OTHER PM_OIDC_CONFIRM_LOGOUT
   HANDLER
 );
-our %EXPORT_TAGS = ( 'all' => [ @EXPORT, 'import' ], );
+our %EXPORT_TAGS = ( 'all' => [ @EXPORT_OK, 'import' ], );
 
-our @EXPORT_OK = ( @{ $EXPORT_TAGS{'all'} } );
+our @EXPORT = qw(import PE_OK);
 
 1;

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Main/Request.pm

@@ -23,7 +23,7 @@ package Lemonldap::NG::Portal::Main::Request;
 
 use strict;
 use Mouse;
-use Lemonldap::NG::Portal::Main::Constants;
+use Lemonldap::NG::Portal::Main::Constants ':all';
 
 extends 'Lemonldap::NG::Common::PSGI::Request';
 

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/UserDB/DBI.pm

@@ -2,7 +2,7 @@ package Lemonldap::NG::Portal::UserDB::DBI;
 
 use strict;
 use Mouse;
-use Lemonldap::NG::Portal::Main::Constants;
+use Lemonldap::NG::Portal::Main::Constants qw(PE_OK PE_ERROR PE_BADCREDENTIALS);
 
 extends 'Lemonldap::NG::Portal::Lib::DBI';
 

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/UserDB/Demo.pm

@@ -7,7 +7,7 @@ package Lemonldap::NG::Portal::UserDB::Demo;
 
 use strict;
 use Mouse;
-use Lemonldap::NG::Portal::Main::Constants;
+use Lemonldap::NG::Portal::Main::Constants qw(PE_OK PE_USERNOTFOUND);
 
 extends 'Lemonldap::NG::Portal::Main::Module';
 

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/UserDB/LDAP.pm

@@ -2,7 +2,8 @@ package Lemonldap::NG::Portal::UserDB::LDAP;
 
 use strict;
 use Mouse;
-use Lemonldap::NG::Portal::Main::Constants;
+use Lemonldap::NG::Portal::Main::Constants
+  qw(PE_OK PE_LDAPCONNECTFAILED PE_LDAPERROR PE_BADCREDENTIALS);
 use Lemonldap::NG::Portal::Lib::LDAP;
 
 extends 'Lemonldap::NG::Portal::Main::Module';