Verify that Redirect and POST don't call SOAP [SAML] (#595)

lemonldap-ng-portal/t/30-Auth-and-issuer-SAML-POST-IdP-initiated.t

@@ -204,30 +204,9 @@ no warnings 'redefine';
 
 sub LWP::UserAgent::request {
     my ( $self, $req ) = @_;
-    ok( $req->uri =~ m#http://auth.sp.com(.*)#, 'Request from IdP to SP' );
-    my $url = $1;
-    my $res;
-    my $s = $req->content;
-    ok(
-        $res = $sp->_post(
-            $url, IO::String->new($s),
-            length => length($s),
-            type   => 'application/xml',
-        ),
-        'Execute request'
-    );
-    ok( ( $res->[0] == 200 or $res->[0] == 400 ), 'Response is 200 or 400' )
-      or explain( $res->[0], "200 or 400" );
-    ok( getHeader( $res, 'Content-Type' ) =~ m#^application/xml#,
-        'Content is XML' )
-      or explain( $res->[1], 'Content-Type => application/xml' );
-    my $httpResp = HTTP::Response->new( $res->[0], 'OK' );
-
-    while ( my $name = shift @{ $res->[1] } ) {
-        $httpResp->header( $name, shift( @{ $res->[1] } ) );
-    }
-    $httpResp->content( join( '', @{ $res->[2] } ) );
-    count(4);
+    fail('POST should not launch SOAP requests');
+    my $httpResp = HTTP::Response->new(500);
+    count(1);
     return $httpResp;
 }
 

lemonldap-ng-portal/t/30-Auth-and-issuer-SAML-POST.t

@@ -266,6 +266,17 @@ count($maintests);
 clean_sessions();
 done_testing( count() );
 
+# Redefine LWP methods for tests
+no warnings 'redefine';
+
+sub LWP::UserAgent::request {
+    my ( $self, $req ) = @_;
+    fail('POST should not launch SOAP requests');
+    my $httpResp = HTTP::Response->new(500);
+    count(1);
+    return $httpResp;
+}
+
 sub switch {
     my $type = shift;
     @Lemonldap::NG::Handler::Main::Reload::_onReload = @{

lemonldap-ng-portal/t/30-Auth-and-issuer-SAML-Redirect-IdP-initiated.t

@@ -148,30 +148,9 @@ no warnings 'redefine';
 
 sub LWP::UserAgent::request {
     my ( $self, $req ) = @_;
-    ok( $req->uri =~ m#http://auth.sp.com(.*)#, 'Request from SP to IdP' );
-    my $url = $1;
-    my $res;
-    my $s = $req->content;
-    ok(
-        $res = $sp->_post(
-            $url, IO::String->new($s),
-            length => length($s),
-            type   => 'application/xml',
-        ),
-        'Execute request'
-    );
-    ok( ( $res->[0] == 200 or $res->[0] == 400 ), 'Response is 200 or 400' )
-      or explain( $res->[0], "200 or 400" );
-    ok( getHeader( $res, 'Content-Type' ) =~ m#^application/xml#,
-        'Content is XML' )
-      or explain( $res->[1], 'Content-Type => application/xml' );
-    my $httpResp = HTTP::Response->new( $res->[0], 'OK' );
-
-    while ( my $name = shift @{ $res->[1] } ) {
-        $httpResp->header( $name, shift( @{ $res->[1] } ) );
-    }
-    $httpResp->content( join( '', @{ $res->[2] } ) );
-    count(4);
+    fail('Redirect should not launch SOAP requests');
+    my $httpResp = HTTP::Response->new(500);
+    count(1);
     return $httpResp;
 }
 

lemonldap-ng-portal/t/30-Auth-and-issuer-SAML-Redirect.t

@@ -205,6 +205,17 @@ count($maintests);
 clean_sessions();
 done_testing( count() );
 
+# Redefine LWP methods for tests
+no warnings 'redefine';
+
+sub LWP::UserAgent::request {
+    my ( $self, $req ) = @_;
+    fail('Redirect should not launch SOAP requests');
+    my $httpResp = HTTP::Response->new(500);
+    count(1);
+    return $httpResp;
+}
+
 sub switch {
     my $type = shift;
     @Lemonldap::NG::Handler::Main::Reload::_onReload = @{