1. 09 Jun, 2021 10 commits
  2. 18 Mar, 2021 1 commit
  3. 28 Jan, 2021 5 commits
  4. 21 Oct, 2020 1 commit
    • Jose Juan Iglesias's avatar
      We have several virtual windows servers (vmware virtual machines) each of · 5a9420fb
      Jose Juan Iglesias authored
      which configured with two VMXNET3 interfaces. One of this interfaces
      belongs to an isolated LAN: it hasn't got gateway configuration.
      When these servers transmit their inventories to the OCS server, all of
      them provide this kind of wrong network information:
              <NETWORKS>
                  <DESCRIPTION>vmxnet3 Ethernet Adapter</DESCRIPTION>
                  <TYPE>Ethernet</TYPE>
                  <TYPEMIB>ethernetCsmacd</TYPEMIB>
                  <SPEED>1 Gb/s</SPEED>
                  <MACADDR>omitted</MACADDR>
                  <STATUS>Up</STATUS>
                  <IPADDRESS>10.1.1.93</IPADDRESS>
                  <IPMASK>255.255.255.0</IPMASK>
                  <IPGATEWAY>10.1.1.254</IPGATEWAY>
                  <IPSUBNET>10.1.1.0</IPSUBNET>
                  <IPDHCP />
                  <MTU />
              </NETWORKS>
              <NETWORKS>
                  <DESCRIPTION>vmxnet3 Ethernet Adapter #2</DESCRIPTION>
                  <TYPE>Ethernet</TYPE>
                  <TYPEMIB>ethernetCsmacd</TYPEMIB>
                  <SPEED>1 Gb/s</SPEED>
                  <MACADDR>omitted</MACADDR>
                  <STATUS>Up</STATUS>
                  <IPADDRESS>172.16.16.93</IPADDRESS>
                  <IPMASK>255.255.255.0</IPMASK>
                  <IPGATEWAY>10.1.1.254</IPGATEWAY>
                  <IPSUBNET>10.1.1.0</IPSUBNET>
                  <IPDHCP />
                  <MTU />
              </NETWORKS>
      As you can see, the latter adapter appears as having the same gateway and
      mask as those of the former.
      After some testing with the code of the Agent, we saw that these interfaces are
      precessed by the function CIPHelper::GetNetworkAdapters one after the other, and
      the values of the object cAdapter are not reset anywhere before the end of the loop.
      So the information not provided by the second interface doesn't update those corresponding
      fields which already hold information belonging to the first interface. (AF_INET family)
      
      Besides, also in the case of AF_INET family, the determination of the subnet mask of an
      interface depends on its having a gateway configured. If an interface doesn't have gateway,
      the code won't get its subnet mask. We have moved the code that determines the mask outside
      the gateway condition.
      5a9420fb
  5. 11 Sep, 2020 2 commits
  6. 07 Sep, 2020 2 commits
  7. 04 Sep, 2020 1 commit
  8. 03 Sep, 2020 1 commit
  9. 01 Sep, 2020 1 commit
  10. 28 Jul, 2020 1 commit
  11. 24 Jul, 2020 7 commits
  12. 20 Jul, 2020 1 commit
  13. 29 Jun, 2020 1 commit
  14. 13 Jun, 2020 1 commit
  15. 09 Jun, 2020 2 commits
  16. 08 Jun, 2020 2 commits
  17. 05 Jun, 2020 1 commit