Cleaning useless code

lemonldap-ng-manager/lib/Lemonldap/NG/Manager/2ndFA.pm

@@ -16,7 +16,7 @@ use feature 'state';
 extends 'Lemonldap::NG::Common::Conf::AccessLib',
   'Lemonldap::NG::Common::Session::REST';
 
-our $VERSION = '2.0.0';
+our $VERSION = '2.0.2';
 
 #############################
 # I. INITIALIZATION METHODS #
@@ -42,26 +42,10 @@ sub addRoutes {
         ['DELETE']
       );
 
-    ## ADD 2FA DEVICE
-    #->addRoute(
-    #sfa => { ':sessionType' => { ':sessionId' => 'add2FA' } },
-    #['PUT']
-    #)
-
-    ## VERIFY 2FA DEVICE
-    #->addRoute(
-    #sfa => { ':sessionType' => { ':sessionId' => 'verify2FA' } },
-    #['POST']
-    #);
-
     $self->setTypes($conf);
-
-    #$self->{ipField}              ||= 'ipAddr';
     $self->{multiValuesSeparator} ||= '; ';
     $self->{hiddenAttributes} //= "_password";
-    $self->{TOTPCheck} = '1';
-    $self->{U2FCheck}  = '1';
-    $self->{UBKCheck}  = '1';
+    $self->{TOTPCheck} = $self->{U2FCheck} = $self->{UBKCheck}  = '1';
 }
 
 ###################
@@ -91,26 +75,6 @@ sub del2F {
     }
 }
 
-#sub add2FA {
-
-#my ( $self, $req, $session, $skey ) = @_;
-
-#eval 'use Crypt::U2F::Server::Simple';
-#if ($@) {
-#$self->error("Can't load U2F library: $@");
-#return 0;
-#}
-
-#return $self->addU2FKey( $req, $session, $skey );
-#}
-
-#sub verify2FA {
-
-#my ( $self, $req, $session, $skey ) = @_;
-
-#return $self->addU2FKey( $req, $session, $skey );
-#}
-
 ########################
 # III. DISPLAY METHODS #
 ########################
@@ -120,7 +84,6 @@ sub sfa {
 
     # Case 1: only one session is required
     if ($session) {
-
         return $self->session( $req, $session, $skey );
     }
 

lemonldap-ng-portal/lib/Lemonldap/NG/Portal/2F/Register/U2F.pm

@@ -298,9 +298,6 @@ sub run {
             [ 'Content-Type' => 'application/json', 'Content-Length' => 12, ],
             ['{"result":1}']
         ];
-        my $err = Crypt::U2F::Server::Simple::lastError();
-        $self->userLogger->warn("U2F Unregistration failed: $err");
-        return $self->p->sendError( $req, $err, 200 );
     }
     else {
         $self->logger->error("Unknown U2F action -> $action");
@@ -316,7 +313,6 @@ sub loadUser {
     # Read existing 2FDevices
     $self->logger->debug("Looking for 2F Devices ...");
     my ( $kh, $uk, $_2fDevices );
-
     my @u2fs = ();
 
     if ( $req->userData->{_2fDevices} ) {