From 2bab6d52ed7ee92cdb7be46c085a91c3fb95cd95 Mon Sep 17 00:00:00 2001
From: Vincent Massol <vincent@massol.net>
Date: Fri, 29 May 2020 22:24:37 +0200
Subject: [PATCH] [Misc] Added explicit mention that some revapi ignores are
 not a breakage.

---
 xwiki-platform-core/pom.xml | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/xwiki-platform-core/pom.xml b/xwiki-platform-core/pom.xml
index 6e50d5d1a5e..8f491b5480f 100644
--- a/xwiki-platform-core/pom.xml
+++ b/xwiki-platform-core/pom.xml
@@ -168,26 +168,27 @@
               <item>
                 <code>java.method.removed</code>
                 <old>method void com.xpn.xwiki.doc.XWikiDocument::rename(java.lang.String, java.util.List&lt;java.lang.String&gt;, com.xpn.xwiki.XWikiContext) throws com.xpn.xwiki.XWikiException</old>
-                <justification>Old deprecated method that has been moved to legacy.</justification>
+                <justification>Not a breakage. Old deprecated method that has been moved to legacy.</justification>
               </item>
               <item>
                 <code>java.method.removed</code>
                 <old>method void com.xpn.xwiki.doc.XWikiDocument::rename(java.lang.String, java.util.List&lt;java.lang.String&gt;, java.util.List&lt;java.lang.String&gt;, com.xpn.xwiki.XWikiContext) throws com.xpn.xwiki.XWikiException</old>
-                <justification>Old deprecated method that has been moved to legacy.</justification>
+                <justification>Not a breakage. Old deprecated method that has been moved to legacy.</justification>
               </item>
               <item>
                 <code>java.method.removed</code>
                 <old>method void com.xpn.xwiki.doc.XWikiDocument::rename(java.lang.String, com.xpn.xwiki.XWikiContext) throws com.xpn.xwiki.XWikiException</old>
-                <justification>Old deprecated method that has been moved to legacy.</justification>
+                <justification>Not a breakage. Old deprecated method that has been moved to legacy.</justification>
               </item>
+
             </revapi.ignore>
-          </analysisConfiguration>
-        </configuration>
-      </plugin>
-    </plugins>
-  </build>
-  <modules>
-    <!-- Sorted Alphabetically -->
+            </analysisConfiguration>
+          </configuration>
+        </plugin>
+      </plugins>
+    </build>
+    <modules>
+      <!-- Sorted Alphabetically -->
     <module>xwiki-platform-activeinstalls</module>
     <module>xwiki-platform-activitystream</module>
     <module>xwiki-platform-administration</module>
-- 
GitLab