From 3281b70d24baef64d61def687bb3d75fc6666cd3 Mon Sep 17 00:00:00 2001
From: Marius Dumitru Florea <marius@xwiki.com>
Date: Tue, 5 Jul 2022 13:05:51 +0300
Subject: [PATCH] XWIKI-19913: PDF export sometimes fails when setting the
cookies for the headless Chrome browser * Cookies can be duplicated. The code
shouldn't break when it happens. Also, it's good to log all cookies, even
duplicated ones.
---
.../org/xwiki/export/pdf/internal/chrome/ChromeManager.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-default/src/main/java/org/xwiki/export/pdf/internal/chrome/ChromeManager.java b/xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-default/src/main/java/org/xwiki/export/pdf/internal/chrome/ChromeManager.java
index fe778cd3984..59550f39c73 100644
--- a/xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-default/src/main/java/org/xwiki/export/pdf/internal/chrome/ChromeManager.java
+++ b/xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-default/src/main/java/org/xwiki/export/pdf/internal/chrome/ChromeManager.java
@@ -307,8 +307,8 @@ public CookieParam toCookieParam(Cookie servletCookie)
*/
public void setCookies(ChromeDevToolsService tabDevToolsService, List<CookieParam> cookies)
{
- this.logger.debug("Setting cookies [{}].",
- cookies.stream().collect(Collectors.toMap(CookieParam::getName, CookieParam::getValue)));
+ this.logger.debug("Setting cookies [{}].", cookies.stream()
+ .map(cookie -> String.format("%s: %s", cookie.getName(), cookie.getValue())).collect(Collectors.toList()));
Network network = tabDevToolsService.getNetwork();
network.enable();
network.clearBrowserCookies();
--
GitLab