Skip to content
Snippets Groups Projects
  • Tim Kinnane's avatar
    03f3db25
    Prevent last admin removal (#3971) · 03f3db25
    Tim Kinnane authored
    * More admin checks
    
    # Conflicts:
    #	packages/rocketchat-lib/server/methods/insertOrUpdateUser.coffee
    
    * missing server side validation
    
    # Conflicts:
    #	packages/rocketchat-ui-flextab/flex-tab/tabs/userEdit.coffee
    
    * Remove last admin check for removeUserFromRoom
    
    * Move and fix last admin check for role removal
    
    Check was on change admin status method, but that didn’t catch direct removal of user from role admin view.
    
    * Fix last admin check for insert/update/delete user
    
    Was checking if only one admin but not if the updated user was admin, preventing all updates.
    
    * Allow translation of last admin error
    
    * Fix assigning admin permission bypass
    03f3db25
    History
    Prevent last admin removal (#3971)
    Tim Kinnane authored
    * More admin checks
    
    # Conflicts:
    #	packages/rocketchat-lib/server/methods/insertOrUpdateUser.coffee
    
    * missing server side validation
    
    # Conflicts:
    #	packages/rocketchat-ui-flextab/flex-tab/tabs/userEdit.coffee
    
    * Remove last admin check for removeUserFromRoom
    
    * Move and fix last admin check for role removal
    
    Check was on change admin status method, but that didn’t catch direct removal of user from role admin view.
    
    * Fix last admin check for insert/update/delete user
    
    Was checking if only one admin but not if the updated user was admin, preventing all updates.
    
    * Allow translation of last admin error
    
    * Fix assigning admin permission bypass