Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
R
Rocket.Chat
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
RocketChat
Rocket.Chat
Commits
05f1b636
Commit
05f1b636
authored
8 years ago
by
Gabriel Engel
Browse files
Options
Downloads
Plain Diff
Merge pull request #3459 from ndarilek/develop
Use <button/> rather than <i/> for buttons
parents
56af0dfa
11da1d15
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
packages/rocketchat-ui-flextab/flex-tab/flexTabBar.html
+1
-1
1 addition, 1 deletion
packages/rocketchat-ui-flextab/flex-tab/flexTabBar.html
packages/rocketchat-ui/views/app/videoCall/videoCall.html
+4
-4
4 additions, 4 deletions
packages/rocketchat-ui/views/app/videoCall/videoCall.html
with
5 additions
and
5 deletions
packages/rocketchat-ui-flextab/flex-tab/flexTabBar.html
+
1
−
1
View file @
05f1b636
<template
name=
"flexTabBar"
>
{{#each buttons}}
<div
class=
"tab-button {{active}} {{visible}}"
title=
"{{title}}"
>
<
i
class=
"{{icon}}"
aria-label=
"{{title}}"
role=
"button"
tabindex=
"0"
></i
>
<
button
aria-label=
"{{title}}"
><i
class=
"{{icon}}"
></i></button
>
</div>
{{/each}}
</template>
This diff is collapsed.
Click to expand it.
packages/rocketchat-ui/views/app/videoCall/videoCall.html
+
4
−
4
View file @
05f1b636
...
...
@@ -13,10 +13,10 @@
{{#unless audioAndVideoEnabled}}
<div
class=
"video-muted-overlay"
>
{{#unless audioEnabled}}
<i
class=
"icon-mute"
></i>
<button>
<i
class=
"icon-mute"
></i>
</button>
{{/unless}}
{{#unless videoEnabled}}
<i
class=
"icon-eye-off"
></i>
<button>
<i
class=
"icon-eye-off"
></i>
</button>
{{/unless}}
</div>
{{/unless}}
...
...
@@ -34,9 +34,9 @@
{{#if videoActive}}
<button
class=
"stop-call button red"
><i
class=
"icon-stop"
></i>
{{_ "Stop"}}
</button>
{{#if audioEnabled}}
<button
class=
"disable-audio button red"
title=
"{{_ 'Mute'}}"
><i
class=
"icon-mute"
></i></button>
<button
class=
"disable-audio button red"
title=
"{{_
'Mute'}}"
aria-label=
"{{_
'Mute'}}"
><i
class=
"icon-mute"
></i></button>
{{else}}
<button
class=
"enable-audio button"
title=
"{{_ 'Unmute'}}"
><i
class=
"icon-mic"
></i></button>
<button
class=
"enable-audio button"
title=
"{{_
'Unmute'}}"
aria-label=
"{{_
'Unmute'}}"
><i
class=
"icon-mic"
></i></button>
{{/if}}
{{#if videoEnabled}}
<button
class=
"disable-video button red"
><i
class=
"icon-eye-off"
></i></button>
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment