fix: Unexpected error when loading webdav files (#35257)

.changeset/four-houses-doubt.md

+---
+'@rocket.chat/meteor': patch
+---
+
+Fixes an issue where an unexpected error is thrown when webdav node doesn't have the mime parameter

apps/meteor/client/views/room/webdav/WebdavFilePickerModal/lib/getNodeIconType.spec.ts

+import { faker } from '@faker-js/faker';
+
+import { getNodeIconType } from './getNodeIconType';
+
+it('should return clip icon if file does not have mime type', () => {
+	const result = getNodeIconType(faker.system.fileName(), faker.system.fileType(), undefined);
+	expect(result.icon).toBe('clip');
+});
+
+it('should return folder icon if file type is directory', () => {
+	const result = getNodeIconType(faker.system.fileName(), 'directory', undefined);
+	expect(result.icon).toBe('folder');
+});

apps/meteor/client/views/room/webdav/WebdavFilePickerModal/lib/getNodeIconType.ts

 import type { Keys as IconName } from '@rocket.chat/icons';
 
+// TODO: This function should be simplified, it only needs to return the icon name
 export const getNodeIconType = (
 	basename: string,
 	fileType: string,
@@ -13,20 +14,17 @@ export const getNodeIconType = (
 		extension = '';
 	}
 
-	if (!mime) {
-		throw new Error('mime is required');
-	}
-
 	if (fileType === 'directory') {
 		icon = 'folder';
 		type = 'directory';
-	} else if (mime.match(/application\/pdf/)) {
+	} else if (mime?.match(/application\/pdf/)) {
 		icon = 'file-pdf';
 		type = 'pdf';
-	} else if (['application/vnd.oasis.opendocument.text', 'application/vnd.oasis.opendocument.presentation'].includes(mime)) {
+	} else if (mime && ['application/vnd.oasis.opendocument.text', 'application/vnd.oasis.opendocument.presentation'].includes(mime)) {
 		icon = 'file-document';
 		type = 'document';
 	} else if (
+		mime &&
 		[
 			'application/vnd.ms-excel',
 			'application/vnd.oasis.opendocument.spreadsheet',
@@ -35,7 +33,7 @@ export const getNodeIconType = (
 	) {
 		icon = 'file-sheets';
 		type = 'sheets';
-	} else if (['application/vnd.ms-powerpoint', 'application/vnd.oasis.opendocument.presentation'].includes(mime)) {
+	} else if (mime && ['application/vnd.ms-powerpoint', 'application/vnd.oasis.opendocument.presentation'].includes(mime)) {
 		icon = 'file-sheets';
 		type = 'ppt';
 	}