Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
R
Rocket.Chat
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
RocketChat
Rocket.Chat
Commits
14b733fa
Commit
14b733fa
authored
2 days ago
by
MartinSchoeler
Browse files
Options
Downloads
Patches
Plain Diff
fix reviews
parent
911c1fd8
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
apps/meteor/tests/e2e/omnichannel/omnichannel-chat-history.spec.ts
+2
-2
2 additions, 2 deletions
...or/tests/e2e/omnichannel/omnichannel-chat-history.spec.ts
apps/meteor/tests/e2e/page-objects/omnichannel-info.ts
+1
-1
1 addition, 1 deletion
apps/meteor/tests/e2e/page-objects/omnichannel-info.ts
with
3 additions
and
3 deletions
apps/meteor/tests/e2e/omnichannel/omnichannel-chat-history.spec.ts
+
2
−
2
View file @
14b733fa
...
...
@@ -77,12 +77,12 @@ test.describe('Omnichannel chat history', () => {
await
api
.
post
(
'
/permissions.update
'
,
{
permissions
:
[{
_id
:
'
preview-c-room
'
,
roles
:
[]
}]
});
await
test
.
step
(
'
Expect
to not be able
to see conversation history
'
,
async
()
=>
{
await
test
.
step
(
'
Expect
agent
to see conversation history
, but not join room
'
,
async
()
=>
{
await
agent
.
page
.
reload
();
await
agent
.
poHomeOmnichannel
.
contacts
.
contactInfo
.
historyItem
.
click
();
await
agent
.
poHomeOmnichannel
.
contacts
.
contactInfo
.
historyMessage
.
click
();
await
agent
.
poHomeOmnichannel
.
contacts
.
contactInfo
.
o
penChat
Btn
.
click
();
await
agent
.
poHomeOmnichannel
.
contacts
.
contactInfo
.
btnO
penChat
.
click
();
// Should not show the NoSubscribedRoom.tsx component on livechat rooms
await
expect
(
agent
.
page
.
locator
(
'
div >> text=This conversation is already closed.
'
)).
toBeVisible
();
...
...
This diff is collapsed.
Click to expand it.
apps/meteor/tests/e2e/page-objects/omnichannel-info.ts
+
1
−
1
View file @
14b733fa
...
...
@@ -27,7 +27,7 @@ export class OmnichannelContactInfo extends OmnichannelManageContact {
return
this
.
dialogContactInfo
.
getByRole
(
'
listitem
'
).
first
();
}
get
o
penChat
Btn
():
Locator
{
get
btnO
penChat
():
Locator
{
return
this
.
dialogContactInfo
.
getByRole
(
'
button
'
,
{
name
:
'
Open chat
'
});
}
}
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment