Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
R
Rocket.Chat
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
RocketChat
Rocket.Chat
Commits
3569b0a9
Unverified
Commit
3569b0a9
authored
4 months ago
by
Douglas Gubert
Committed by
GitHub
4 months ago
Browse files
Options
Downloads
Patches
Plain Diff
fix: incorrect validation for networking permission on Deno process (#33786)
parent
c2a48e3d
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
.changeset/nervous-rivers-fry.md
+6
-0
6 additions, 0 deletions
.changeset/nervous-rivers-fry.md
packages/apps-engine/src/server/runtime/deno/AppsEngineDenoRuntime.ts
+1
-1
1 addition, 1 deletion
...s-engine/src/server/runtime/deno/AppsEngineDenoRuntime.ts
with
7 additions
and
1 deletion
.changeset/nervous-rivers-fry.md
0 → 100644
+
6
−
0
View file @
3569b0a9
---
'
@rocket.chat/apps-engine'
:
patch
'
@rocket.chat/meteor'
:
patch
---
Fixed an issue that would grant network permission to app's processes in wrong cases
This diff is collapsed.
Click to expand it.
packages/apps-engine/src/server/runtime/deno/AppsEngineDenoRuntime.ts
+
1
−
1
View file @
3569b0a9
...
...
@@ -132,7 +132,7 @@ export class DenoRuntimeSubprocessController extends EventEmitter {
// If the app doesn't request any permissions, it gets the default set of permissions, which includes "networking"
// If the app requests specific permissions, we need to check whether it requests "networking" or not
if
(
!
this
.
appPackage
.
info
.
permissions
||
this
.
appPackage
.
info
.
permissions
.
findIndex
((
p
)
=>
p
.
name
===
'
networking.default
'
))
{
if
(
!
this
.
appPackage
.
info
.
permissions
||
this
.
appPackage
.
info
.
permissions
.
findIndex
((
p
)
=>
p
.
name
===
'
networking.default
'
)
!==
-
1
)
{
hasNetworkingPermission
=
true
;
}
...
...
This diff is collapsed.
Click to expand it.
Git Mirror User
@gitmirror
mentioned in commit
e8022148
·
4 months ago
mentioned in commit
e8022148
mentioned in commit e80221484209edeb86a281ed26dce490ebcf13fc
Toggle commit list
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment