Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
R
Rocket.Chat
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package registry
Model registry
Operate
Terraform modules
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
RocketChat
Rocket.Chat
Commits
4909e1cc
Unverified
Commit
4909e1cc
authored
2 months ago
by
Júlia Jaeger Foresti
Committed by
GitHub
2 months ago
Browse files
Options
Downloads
Patches
Plain Diff
regression: sidebar scrolling horizontally (#35048)
parent
64685ca3
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
apps/meteor/client/sidebarv2/RoomMenu.tsx
+1
-1
1 addition, 1 deletion
apps/meteor/client/sidebarv2/RoomMenu.tsx
apps/meteor/tests/e2e/page-objects/fragments/sidebar.ts
+1
-1
1 addition, 1 deletion
apps/meteor/tests/e2e/page-objects/fragments/sidebar.ts
with
2 additions
and
2 deletions
apps/meteor/client/sidebarv2/RoomMenu.tsx
+
1
−
1
View file @
4909e1cc
...
...
@@ -23,7 +23,7 @@ const RoomMenu = ({ rid, unread, threadUnread, alert, roomOpen, type, cl, name =
const
isUnread
=
alert
||
unread
||
threadUnread
;
const
sections
=
useRoomMenuActions
({
rid
,
type
,
name
,
isUnread
,
cl
,
roomOpen
,
hideDefaultOptions
});
return
<
GenericMenu
detached
className
=
'rcx-sidebar-item__menu'
title
=
{
t
(
'
Options
'
)
}
mini
aria-keyshortcuts
=
'alt'
sections
=
{
sections
}
/>;
return
<
GenericMenu
detached
title
=
{
t
(
'
Options
'
)
}
mini
aria-keyshortcuts
=
'alt'
sections
=
{
sections
}
/>;
};
export
default
memo
(
RoomMenu
);
This diff is collapsed.
Click to expand it.
apps/meteor/tests/e2e/page-objects/fragments/sidebar.ts
+
1
−
1
View file @
4909e1cc
...
...
@@ -78,7 +78,7 @@ export class Sidebar {
async
markItemAsUnread
(
item
:
Locator
):
Promise
<
void
>
{
await
item
.
hover
();
await
item
.
focus
();
await
item
.
locator
(
'
.rcx-sidebar-item__menu
'
).
click
();
await
item
.
getByRole
(
'
button
'
,
{
name
:
'
Options
'
,
exact
:
true
}
).
click
();
await
this
.
page
.
getByRole
(
'
menuitem
'
,
{
name
:
'
Mark Unread
'
}).
click
();
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment