chore: throttle exceptions counter increment (#29719)

apps/meteor/app/error-handler/server/lib/RocketChat.ErrorHandler.ts

@@ -3,6 +3,11 @@ import { Settings, Users, Rooms } from '@rocket.chat/models';
 
 import { settings } from '../../../settings/server';
 import { sendMessage } from '../../../lib/server';
+import { throttledCounter } from '../../../../lib/utils/throttledCounter';
+
+const incException = throttledCounter((counter) => {
+	Settings.incrementValueById('Uncaught_Exceptions_Count', counter).catch(console.error);
+}, 10000);
 
 class ErrorHandler {
 	reporting: boolean;
@@ -40,7 +45,7 @@ class ErrorHandler {
 
 	async registerHandlers() {
 		process.on('uncaughtException', async (error) => {
-			await Settings.incrementValueById('Uncaught_Exceptions_Count');
+			incException();
 			if (!this.reporting) {
 				return;
 			}

apps/meteor/app/lib/server/lib/meteorFixes.js

 import { MongoInternals } from 'meteor/mongo';
 import { Settings } from '@rocket.chat/models';
 
+import { throttledCounter } from '../../../../lib/utils/throttledCounter';
+
 const timeoutQuery = parseInt(process.env.OBSERVERS_CHECK_TIMEOUT) || 2 * 60 * 1000;
 const interval = parseInt(process.env.OBSERVERS_CHECK_INTERVAL) || 60 * 1000;
 const debug = Boolean(process.env.OBSERVERS_CHECK_DEBUG);
@@ -44,6 +46,10 @@ setInterval(() => {
 		});
 }, interval);
 
+const incException = throttledCounter((counter) => {
+	Settings.incrementValueById('Uncaught_Exceptions_Count', counter).catch(console.error);
+}, 10000);
+
 /**
  * If some promise is rejected and doesn't have a catch (unhandledRejection) it may cause this finally
  * here https://github.com/meteor/meteor/blob/be6e529a739f47446950e045f4547ee60e5de7ae/packages/mongo/oplog_tailing.js#L348
@@ -58,8 +64,8 @@ setInterval(() => {
  * we will start respecting this and exit the process to prevent these kind of problems.
  */
 
-process.on('unhandledRejection', async (error) => {
-	await Settings.incrementValueById('Uncaught_Exceptions_Count');
+process.on('unhandledRejection', (error) => {
+	incException();
 
 	console.error('=== UnHandledPromiseRejection ===');
 	console.error(error);

apps/meteor/ee/server/startup/seatsCap.ts

 import { Meteor } from 'meteor/meteor';
 import type { IUser } from '@rocket.chat/core-typings';
 import { Users } from '@rocket.chat/models';
+import { throttle } from 'underscore';
 
 import { callbacks } from '../../../lib/callbacks';
 import { canAddNewUser, getMaxActiveUsers, onValidateLicenses } from '../../app/license/server/license';
@@ -79,7 +80,7 @@ callbacks.add(
 	'check-max-user-seats',
 );
 
-async function handleMaxSeatsBanners() {
+const handleMaxSeatsBanners = throttle(async function _handleMaxSeatsBanners() {
 	const maxActiveUsers = getMaxActiveUsers();
 
 	if (!maxActiveUsers) {
@@ -106,7 +107,7 @@ async function handleMaxSeatsBanners() {
 	} else {
 		await enableDangerBanner();
 	}
-}
+}, 10000);
 
 callbacks.add('afterCreateUser', handleMaxSeatsBanners, callbacks.priority.MEDIUM, 'handle-max-seats-banners');
 

apps/meteor/lib/utils/throttledCounter.ts

+import { throttle } from 'underscore';
+
+export function throttledCounter(fn: (counter: number) => unknown, wait: number) {
+	let counter = 0;
+
+	const throttledFn = throttle(
+		() => {
+			fn(counter);
+
+			counter = 0;
+		},
+		wait,
+		{ leading: false },
+	);
+
+	return () => {
+		counter++;
+		throttledFn();
+	};
+}