Chore: Rewrite action-links to ts (#25418)

apps/meteor/app/action-links/server/actionLinkHandler.js → apps/meteor/app/action-links/server/actionLinkHandler.ts

@@ -11,7 +11,16 @@ Meteor.methods({
 
 		const message = actionLinks.getMessage(name, messageId);
 
-		const actionLink = message.actionLinks[name];
+		if (!message) {
+			throw new Meteor.Error('error-invalid-message', 'Invalid message', { method: 'actionLinkHandler' });
+		}
+
+		// NOTE: based on types (and how FE uses it) this should be the way of doing it
+		const actionLink = message.actionLinks?.find((action) => action.method_id === name);
+
+		if (!actionLink) {
+			throw new Meteor.Error('error-invalid-actionlink', 'Invalid action link', { method: 'actionLinkHandler' });
+		}
 
 		actionLinks.actions[actionLink.method_id](message, actionLink.params);
 	},

apps/meteor/app/action-links/server/lib/actionLinks.js → apps/meteor/app/action-links/server/lib/actionLinks.ts

+import { IMessage } from '@rocket.chat/core-typings';
 import { Meteor } from 'meteor/meteor';
 
 import { getMessageForUser } from '../../../../server/lib/messages/getMessageForUser';
 
-function getMessageById(messageId) {
+function getMessageById(messageId: IMessage['_id']): IMessage | undefined {
 	try {
-		return Promise.await(getMessageForUser(messageId, Meteor.userId()));
+		const user = Meteor.userId();
+		if (!user) {
+			return;
+		}
+		return Promise.await(getMessageForUser(messageId, user));
 	} catch (e) {
 		throw new Meteor.Error(e.message, 'Invalid message', {
 			function: 'actionLinks.getMessage',
@@ -12,13 +17,15 @@ function getMessageById(messageId) {
 	}
 }
 
+type ActionLinkHandler = (message: IMessage, params?: string, instance?: undefined) => void;
+
 // Action Links namespace creation.
 export const actionLinks = {
-	actions: {},
-	register(name, funct) {
+	actions: {} as { [key: string]: ActionLinkHandler },
+	register(name: string, funct: ActionLinkHandler): void {
 		actionLinks.actions[name] = funct;
 	},
-	getMessage(name, messageId) {
+	getMessage(name: string, messageId: IMessage['_id']): IMessage | undefined {
 		const message = getMessageById(messageId);
 
 		if (!message) {
@@ -27,7 +34,7 @@ export const actionLinks = {
 			});
 		}
 
-		if (!message.actionLinks || !message.actionLinks[name]) {
+		if (!message.actionLinks?.some((action) => action.method_id === name)) {
 			throw new Meteor.Error('error-invalid-actionlink', 'Invalid action link', {
 				function: 'actionLinks.getMessage',
 			});

apps/meteor/server/lib/messages/getMessageForUser.ts

@@ -3,7 +3,7 @@ import type { IUser, IMessage } from '@rocket.chat/core-typings';
 import { Messages } from '../../../app/models/server/raw';
 import { canAccessRoomId } from '../../../app/authorization/server';
 
-export async function getMessageForUser(messageId: IMessage['_id'], uid: IUser['_id']): Promise<IMessage | undefined> {
+export async function getMessageForUser(messageId: IMessage['_id'], uid: IUser['_id'] | null): Promise<IMessage | undefined> {
 	if (!uid) {
 		throw new Error('error-invalid-user');
 	}