-
- Downloads
[BREAK] use urlParams on omnichannel/agent/extension/ (#25874)
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> ## Proposed changes (including videos or screenshots) I've noted that our extensions api was not using the same pattern that we use for a lot of `GET`s and `DELETE`s. This will fix an issue when trying to remove an agent from a voip extension.
Showing
- apps/meteor/app/api/server/v1/voip/omnichannel.ts 39 additions, 34 deletionsapps/meteor/app/api/server/v1/voip/omnichannel.ts
- apps/meteor/client/views/admin/settings/groups/voip/RemoveAgentButton.tsx 2 additions, 2 deletions...nt/views/admin/settings/groups/voip/RemoveAgentButton.tsx
- packages/rest-typings/src/v1/voip.ts 4 additions, 2 deletionspackages/rest-typings/src/v1/voip.ts
Loading
Please register or sign in to comment