Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
R
Rocket.Chat
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
RocketChat
Rocket.Chat
Commits
c24b0e5e
Unverified
Commit
c24b0e5e
authored
5 months ago
by
Aleksander Nicacio da Silva
Committed by
GitHub
5 months ago
Browse files
Options
Downloads
Patches
Plain Diff
regression: voip beforeunload listener being added instead of removed (#33511)
parent
6843990c
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
packages/ui-voip/src/providers/VoipProvider.tsx
+1
-1
1 addition, 1 deletion
packages/ui-voip/src/providers/VoipProvider.tsx
with
1 addition
and
1 deletion
packages/ui-voip/src/providers/VoipProvider.tsx
+
1
−
1
View file @
c24b0e5e
...
...
@@ -103,7 +103,7 @@ const VoipProvider = ({ children }: { children: ReactNode }) => {
voipClient
.
networkEmitter
.
off
(
'
disconnected
'
,
onNetworkDisconnected
);
voipClient
.
networkEmitter
.
off
(
'
connectionerror
'
,
onNetworkDisconnected
);
voipClient
.
networkEmitter
.
off
(
'
localnetworkoffline
'
,
onNetworkDisconnected
);
window
.
add
EventListener
(
'
beforeunload
'
,
onBeforeUnload
);
window
.
remove
EventListener
(
'
beforeunload
'
,
onBeforeUnload
);
};
},
[
dispatchToastMessage
,
setStorageRegistered
,
t
,
voipClient
,
voipSounds
]);
...
...
This diff is collapsed.
Click to expand it.
Git Mirror User
@gitmirror
mentioned in commit
38e7d8d5
·
5 months ago
mentioned in commit
38e7d8d5
mentioned in commit 38e7d8d59a293a29ed81d258da2930bcdeec191a
Toggle commit list
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment