Merge pull request #5942 from jaredhilton/develop

Fix 3651, update to /api.../info endpoints to be secure and backwards compatible for mobile clients.

packages/rocketchat-api/package.js

@@ -20,7 +20,12 @@ Package.onUse(function(api) {
 	api.addFiles('server/v1/helpers/getPaginationItems.js', 'server');
 	api.addFiles('server/v1/helpers/getUserFromParams.js', 'server');
 	api.addFiles('server/v1/helpers/parseJsonQuery.js', 'server');
+	api.addFiles('server/v1/helpers/getLoggedInUser.js', 'server');
 
+	//Register default helpers
+	api.addFiles('server/default/helpers/getLoggedInUser.js', 'server');
+
+	//Add default routes
 	api.addFiles('server/default/info.js', 'server');
 	api.addFiles('server/default/metrics.js', 'server');
 

packages/rocketchat-api/server/default/helpers/getLoggedInUser.js

+RocketChat.API.default.helperMethods.set('getLoggedInUser', function _getLoggedInUser() {
+	let user;
+
+	if (this.request.headers['x-auth-token'] && this.request.headers['x-user-id']) {
+		user = RocketChat.models.Users.findOne({
+			'_id': this.request.headers['x-user-id'],
+			'services.resume.loginTokens.hashedToken': Accounts._hashLoginToken(this.request.headers['x-auth-token'])
+		});
+	}
+
+	return user;
+});

packages/rocketchat-api/server/default/info.js

 RocketChat.API.default.addRoute('info', { authRequired: false }, {
 	get: function() {
-		return RocketChat.Info;
+		const user = this.getLoggedInUser();
+
+		if (user && RocketChat.authz.hasRole(user._id, 'admin')) {
+			return RocketChat.API.v1.success({
+				info: RocketChat.Info
+			});
+		}
+
+		return RocketChat.API.v1.success({
+			version: RocketChat.Info.version
+		});
 	}
 });

packages/rocketchat-api/server/v1/helpers/getLoggedInUser.js

+RocketChat.API.v1.helperMethods.set('getLoggedInUser', function _getLoggedInUser() {
+	let user;
+
+	if (this.request.headers['x-auth-token'] && this.request.headers['x-user-id']) {
+		user = RocketChat.models.Users.findOne({
+			'_id': this.request.headers['x-user-id'],
+			'services.resume.loginTokens.hashedToken': Accounts._hashLoginToken(this.request.headers['x-auth-token'])
+		});
+	}
+
+	return user;
+});

packages/rocketchat-api/server/v1/misc.js

 RocketChat.API.v1.addRoute('info', { authRequired: false }, {
 	get: function() {
+		const user = this.getLoggedInUser();
+
+		if (user && RocketChat.authz.hasRole(user._id, 'admin')) {
+			return RocketChat.API.v1.success({
+				info: RocketChat.Info
+			});
+		}
+
 		return RocketChat.API.v1.success({
-			info: RocketChat.Info
+			info: {
+				'version': RocketChat.Info.version
+			}
 		});
 	}
 });

tests/end-to-end/api/00-miscellaneous.js

@@ -29,14 +29,6 @@ describe('miscellaneous', function() {
 				.expect(200)
 				.expect((res) => {
 					expect(res.body).to.have.property('version');
-					expect(res.body).to.have.deep.property('build.date');
-					expect(res.body).to.have.deep.property('build.nodeVersion');
-					expect(res.body).to.have.deep.property('build.arch');
-					expect(res.body).to.have.deep.property('build.platform');
-					expect(res.body).to.have.deep.property('build.osRelease');
-					expect(res.body).to.have.deep.property('build.totalMemory');
-					expect(res.body).to.have.deep.property('build.freeMemory');
-					expect(res.body).to.have.deep.property('build.cpus');
 				})
 				.end(done);
 		});