Skip to content
Snippets Groups Projects
  1. Jun 18, 2022
    • Tasso Evangelista's avatar
      Chore: Replace `useSubscription` with `useSyncExternalStore` (#25909) · 08627518
      Tasso Evangelista authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      08627518
  2. Jun 17, 2022
    • Diego Sampaio's avatar
    • Júlia Jaeger Foresti's avatar
      Chore: Convert RoomMenu (#25914) · 391bb8cc
      Júlia Jaeger Foresti authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      391bb8cc
    • Pierre Lehnen's avatar
      [NEW] Create Team with a member list of usernames (#25868) · 610670ca
      Pierre Lehnen authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
      
      
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      
      
      Co-authored-by: default avatarDouglas Fabris <27704687+dougfabris@users.noreply.github.com>
      Unverified
      610670ca
    • Júlia Jaeger Foresti's avatar
      Chore: Convert apps/meteor/client/sidebar/search (#25754) · 92e32307
      Júlia Jaeger Foresti authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      92e32307
    • Douglas Fabris's avatar
      Chore: Split useUserInfoActions into small hooks (#25747) · b46cb69e
      Douglas Fabris authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      b46cb69e
    • gabriellsh's avatar
      Chore: Watch for package changes (#25910) · 06043f52
      gabriellsh authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      With the current `dev` pipeline, whenever we modify a package (e.g. `api-client`), we have to kill the meteor proccess and run `yarn dev` again in order for the changes to be compiled and the new output to be used by meteor.
      
      This has the drawback of taking a little longer to run the dev environment, since we can't cache a watched buid. In the other hand, it reduces the friction of modifying internal packages since we don't need to rebuild the project for changes to take effect.
      
      This will enable us to move more things to separate packages without affecting the dev experience too much.
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      06043f52
    • Marcos Spessatto Defendi's avatar
    • Guilherme Gazzo's avatar
    • Diego Sampaio's avatar
      [FIX] Settings not being overwritten to their default values (#25891) · 2c05ffd1
      Diego Sampaio authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      2c05ffd1
  3. Jun 16, 2022
    • Luciano Marcos Pierdona Junior's avatar
      [FIX] Update import from `csv-parse` (#25872) · 419f07ab
      Luciano Marcos Pierdona Junior authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      This PR updates the importing of `csv-parse` because the used method wasn't working anymore, we were receiving the following error:
      
      `error: "this.csvParser is not a function"`
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      419f07ab
    • Yash Rajpal's avatar
      Regression: TOTP Modal with new rest api package (#25893) · 750f0ef5
      Yash Rajpal authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
      
      
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      
      
      Co-authored-by: default avatarGuilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
      Unverified
      750f0ef5
  4. Jun 15, 2022
  5. Jun 14, 2022
    • Matheus Barbosa Silva's avatar
      [BREAK] Deactivated team members are added to auto-join rooms (#25016) · 6eb84146
      Matheus Barbosa Silva authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      - Do not add deactivated users to auto-join rooms.
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      1. Create a new team and add a team member to it;
      2. Go to **Administration > Users** and deactivate one of the team members;
      3. Return to the team and add an auto-join channel/group. **_Expected behavior:_** the deactivated user should not be added to the room.
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      6eb84146
    • Tiago Evangelista Pinto's avatar
      Chore: Broken Storybook (#25714) · 66c5a77c
      Tiago Evangelista Pinto authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
      
      
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      There is another small improvement on the way we got storybook files.
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      
      
      Co-authored-by: default avatarTasso Evangelista <2263066+tassoevan@users.noreply.github.com>
      Unverified
      66c5a77c
    • Guilherme Jun Grillo's avatar
      [FIX] User avatar reseting and getting random image (#25603) · 8064fbe0
      Guilherme Jun Grillo authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
      
      
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      - resolve user avatar not being saved after editing the user profile issue
      - resolve user avatar not getting another user picture due to database deletion error
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      1. As a user log in to the app
      2. Click on Avatar/My account
      3. Change the username
      4. Click on `Save changes` -> Should not change the avatar image
      6. Logout and create a new user on the same server
      7. Repeat steps 1 to 4 -> Should not change the avatar image as well
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      
      
      Co-authored-by: default avatarFilipe Marins <9275105+filipemarins@users.noreply.github.com>
      Co-authored-by: default avatarMatheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
      Unverified
      8064fbe0
    • Guilherme Gazzo's avatar
      Chore: Remove old rest api code (#25863) · 7990a01b
      Guilherme Gazzo authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      7990a01b
    • dependabot[bot]'s avatar
      Chore(deps): Bump sharp from 0.30.4 to 0.30.6 (#25719) · 36fe4998
      dependabot[bot] authored
      Bumps [sharp](https://github.com/lovell/sharp) from 0.30.4 to 0.30.6.
      <details>
      <summary>Changelog</summary>
      <p><em>Sourced from <a href="https://github.com/lovell/sharp/blob/main/docs/changelog.md">sharp's changelog</a>.</em></p>
      <blockquote>
      <h3>v0.30.6 - 30th May 2022</h3>
      <ul>
      <li>
      <p>Allow values for <code>limitInputPixels</code> larger than 32-bit.
      <a href="https://github-redirect.dependabot.com/lovell/sharp/issues/3238">#3238</a></p>
      </li>
      <li>
      <p>Ensure brew-installed <code>vips</code> can be detected (regression in 0.30.5).
      <a href="https://github-redirect.dependabot.com/lovell/sharp/issues/3239">#3239</a></p>
      </li>
      </ul>
      <h3>v0.30.5 - 23rd May 2022</h3>
      <ul>
      <li>
      <p>Install: pass <code>PKG_CONFIG_PATH</code> via env rather than substitution.
      <a href="https://github.com/dwisiswant0"><code>@​dwisiswant0</code></a></p>
      </li>
      <li>
      <p>Add support for <code>--libc</code> flag to improve cross-platform installation.
      <a href="https://github-redirect.dependabot.com/lovell/sharp/pull/3160">#3160</a>
      <a href="https://github.com/joonamo"><code>@​joonamo</code></a></p>
      </li>
      <li>
      <p>Allow installation of prebuilt libvips binaries from filesystem.
      <a href="https://github-redirect.dependabot.com/lovell/sharp/pull/3196">#3196</a>
      <a href="https://github.com/ankurparihar"><code>@​ankurparihar</code></a></p>
      </li>
      <li>
      <p>Fix rotate-then-extract for EXIF orientation 2.
      <a href="https://github-redirect.dependabot.com/lovell/sharp/pull/3218">#3218</a>
      <a href="https://github.com/jakob0fischl"><code>@​jakob0fischl</code></a></p>
      </li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a href="https://github.com/lovell/sharp/commit/b91875d3d9fd628b572a12a155df2e783e0812a5"><code>b91875d</code></a> Release v0.30.6</li>
      <li><a href="https://github.com/lovell/sharp/commit/a0568ec0c312e7fa290874ddfa6797b93ffe0a67"><code>a0568ec</code></a> Allow values for limitInputPixels larger than 32-bit <a href="https://github-redirect.dependabot.com/lovell/sharp/issues/3238">#3238</a></li>
      <li><a href="https://github.com/lovell/sharp/commit/48e3ea5e29b98d6e9a5ac842782053e9941d5d00"><code>48e3ea5</code></a> Ensure brew-installed vips can be detected <a href="https://github-redirect.dependabot.com/lovell/sharp/issues/3239">#3239</a></li>
      <li><a href="https://github.com/lovell/sharp/commit/93b29057e4d759ff9251cdef374c62416a16d26b"><code>93b2905</code></a> Docs: changelog and credit for <a href="https://github-redirect.dependabot.com/lovell/sharp/issues/3160">#3160</a></li>
      <li><a href="https://github.com/lovell/sharp/commit/db654de385e06ee6c56a05aa11a11a2e2f781b14"><code>db654de</code></a> Release v0.30.5</li>
      <li><a href="https://github.com/lovell/sharp/commit/a6aeef612be50f5868a77481848b1de674216f0c"><code>a6aeef6</code></a> Install: pass <code>PKG_CONFIG_PATH</code> via env rather than substitution</li>
      <li><a href="https://github.com/lovell/sharp/commit/7bf6cbd66973a4feedbf670aa20ff184f30553d1"><code>7bf6cbd</code></a> Docs: correct links to libvips documentation</li>
      <li><a href="https://github.com/lovell/sharp/commit/04c31b35a7e2d88931e1cb7cde0fe1720e4685b7"><code>04c31b3</code></a> Install: warn about filesystem owner running npm v8+ as root</li>
      <li><a href="https://github.com/lovell/sharp/commit/ee9cdb65987735caca614eceb7098726ebe5fd3c"><code>ee9cdb6</code></a> Bump deps</li>
      <li><a href="https://github.com/lovell/sharp/commit/8960eb8309629c1c97f06aa45e605dad8c97f0c1"><code>8960eb8</code></a> Docs: changelog entry for <a href="https://github-redirect.dependabot.com/lovell/sharp/issues/3218">#3218</a></li>
      <li>Additional commits viewable in <a href="https://github.com/lovell/sharp/compare/v0.30.4...v0.30.6">compare view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=sharp&package-manager=npm_and_yarn&previous-version=0.30.4&new-version=0.30.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores
      
      )
      
      Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
      - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
      
      
      </details>
      
      Co-authored-by: default avatarGuilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
      Unverified
      36fe4998
    • Jean Brito's avatar
      Chore: Convert sidebar/item (#25634) · b32d3803
      Jean Brito authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      b32d3803
  6. Jun 13, 2022
    • Douglas Fabris's avatar
      Chore: Rewrite RoomWithData (#25858) · 83ec2f90
      Douglas Fabris authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      83ec2f90
    • souzaramon's avatar
      Chore: remove unused locators from e2e tests (#25860) · 666740ad
      souzaramon authored
      ## Proposed changes (including videos or screenshots)
      - Remove unused locators
      Unverified
      666740ad
    • Martin Schoeler's avatar
      [FIX] fixes HTML sanitizing error. (#25410) · f8065bf4
      Martin Schoeler authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      If the user sent a HTML message over our product to a livechat user the HTML would get rendered on the message box, this prevents it from happening.
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      try to send some html tags in livechat
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      
      **Will be ready to review as soon as https://github.com/RocketChat/Rocket.Chat/pull/25312
      
       is merged**
      
      Co-authored-by: default avatarCauê Felchar <11652381+cauefcr@users.noreply.github.com>
      Unverified
      f8065bf4
    • Douglas Fabris's avatar
      Chore: Rewrite Admin UsersTable to Typescript (#25698) · 949fcae9
      Douglas Fabris authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
      
      
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      
      
      Co-authored-by: default avatarTasso Evangelista <2263066+tassoevan@users.noreply.github.com>
      Unverified
      949fcae9
    • Felipe's avatar
      Chore: add _id and name options to JSON Schemas (#25813) · e23cd3e0
      Felipe authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
      
      
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      This pull request adds the `roomId` and `roomName` options for the Ajv JSON Schemas on the `packages/rest-typings/src/v1/channels/` and `packages/rest-typings/src/v1/dm/` folders.
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      
      
      Co-authored-by: default avatarGuilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
      Unverified
      e23cd3e0
    • Pierre Lehnen's avatar
      Chore: Remove unused tokenpass integration code (#25831) · 3c1bc073
      Pierre Lehnen authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      3c1bc073
    • Diego Sampaio's avatar
    • Yash Rajpal's avatar
      Chore: RouteGroup for My Account sidebar (#25632) · 81388318
      Yash Rajpal authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
      
      
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      Refactoring My Accounts routes. Allows to add "my account" routes for EE.
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      
      
      Co-authored-by: default avatarDouglas Fabris <27704687+dougfabris@users.noreply.github.com>
      Unverified
      81388318
    • gabriellsh's avatar
      [FIX] Attachments and OEmbed margins (#25713) · 554091c3
      gabriellsh authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      554091c3
    • Guilherme Gazzo's avatar
      Chore: Typescript Sidebar RoomList (#25835) · 2a40792c
      Guilherme Gazzo authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      2a40792c
    • Guilherme Gazzo's avatar
      Chore: Typescript Sidebar RoomList (#25835) · 79d229bf
      Guilherme Gazzo authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      79d229bf
    • Guilherme Gazzo's avatar
      Chore: Typescript Sidebar RoomList (#25835) · 322b6150
      Guilherme Gazzo authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      322b6150
    • Ben Wiederhake's avatar
      [FIX] Client-generated sort parameters in channel directory (#25768) · 5a37518e
      Ben Wiederhake authored
      ## Proposed changes (including videos or screenshots)
      - In the web-client, sorting the channel directory by "Last Message" raises the error "Invalid sort parameter provided".
      
      I don't think a screenshot is necessary, but if you'd like one anyway, here it is:
      
      ![Bildschirmfoto_2022-06-06_12-54-34](https://user-images.githubusercontent.com/2690845/172147996-e9942daf-6819-4eee-afa4-b1c6bce7a650.png)
      
      
      ## Issue(s)
      Closes #25695
      
      ## Steps to test or reproduce
      
      - Open the web client, i.e. navigate your browser to `https://rocketchat.$DOMAIN/home`
      - Click the "Directory" button in the top left, (or just navigate directly to `https://rocketchat.$DOMAIN/directory/channels`)
      - In the table header, click on "Last message" once
      - In the table header, click on "Last message" again
      
      Expected behavior: Clicking "Last message" turns on and then toggles sorting by the date of the last message, either first ascending and then descending, or the other way around.
      
      Actual behavior: The first click sorts the messages in ascending order (good!), the second click shows a red warning box "FIXME", the table content disappears, and is replaced by throbbing grey placeholders.
      
      ### "Good" request (ascending order):
      
      `https://rocketchat.domain.org/api/v1/directory?query=%7B%22type%22%3A%22channels%22%2C%22text%22%3A%22%22%2C%22workspace%22%3A%22local%22%7D&sort=%7B%22lastMessage%22%3A1%7D&count=25`
      
      More easily readable GET parameters:
      
      ```
      query | {"type":"channels","text":"","workspace":"local"}
      sort | {"lastMessage":1}
      count | 25
      ```
      
      Response:
      ```
      {"result":[{"_id":"AAAAAAAAAAAAAAAAA","name":"foobar","fname":"foobar","t":"c","usersCount":10,"ts":"2019-01-01T00:00:00.000Z","default":false,"lastMessage":{"_id":"AAAAAAAAAAAAAAAAA","rid":"AAAAAAAAAAAAAAAAA","msg":"Hello, World!","ts":"2019-01-01T00:00:00.000Z","u":{"_id":"AAAAAAAAAAAAAAAAA","username":"normaluser","name":"normaluser"},"unread":true,"_updatedAt":"2019-01-01T00:00:00.000Z","urls":[],"mentions":[],"channels":[]},"description":"Obviously, this JSON response is heavily censored."}],"count":25,"offset":0,"total":52,"success":true}
      ```
      
      (Obviously, this JSON response is heavily censored, but you get the gist: It was successful.)
      
      ### "Bad" request (descending order):
      
      `https://rocketchat.domain.org/api/v1/directory?query=%7B%22type%22%3A%22channels%22%2C%22text%22%3A%22%22%2C%22workspace%22%3A%22local%22%7D&sort=%7B%22lastMessage%22%3A0%7D&count=25`
      
      More easily readable GET parameters:
      
      ```
      query | {"type":"channels","text":"","workspace":"local"}
      sort | {"lastMessage":0}
      count | 25
      ```
      
      Response:
      ```
      {"success":false,"error":"Invalid sort parameter provided: \"{\"lastMessage\":0}\" [error-invalid-sort]","errorType":"error-invalid-sort","details":{"helperMethod":"parseJsonQuery"}}
      ```
      
      ## Further comments
      
      Version on the server where I noticed this: `https://rocketchat.$DOMAIN/api/info` returns `{"version":"4.8","success":true}`. According to the "Releases" page, this version appeared 5 days ago, so I believe this is up to date.
      
      ### The journey to here
      
      For some reason, the descending order uses the wrong magic number "0", and the server can't interpret that. However, this *used* to work, so I'm not very sure about this.
      
      The error message appears in the source code of the entire organization exactly once: https://github.com/RocketChat/Rocket.Chat/blob/31ae30f30ad71d9e5a1b0cad494b3471a7dd8807/apps/meteor/app/api/server/helpers/parseJsonQuery.ts#L42
      So I'll guess that this is the line of code that generated this particular message.
      
      A few lines above we see that the server only knows 1 and -1 as magic numbers for the sorting:
      https://github.com/RocketChat/Rocket.Chat/blob/31ae30f30ad71d9e5a1b0cad494b3471a7dd8807/apps/meteor/app/api/server/helpers/parseJsonQuery.ts#L35
      This matches the observed bug: The browser sends 1 (which works) and 0 (which doesn't work).
      
      Generally, it seems that the web client actually uses the strings "asc" and "desc" internally, which are hard to mix up. So I assume that it's the conversion of that is broken somehow.
      
      Exactly this seems to be the case here:
      https://github.com/RocketChat/Rocket.Chat/blob/31ae30f30ad71d9e5a1b0cad494b3471a7dd8807/apps/meteor/client/views/directory/hooks.js#L11
      
      The code around it produces exactly the kind of query seen in the network log, and can also produce the buggy parameter `sort: 0`. This either fixes bug #25695, or a different bug of the same kind.
      
      I am not sure how to add tests for this, can someone do this for me or show me where to start? I'm actually just an end-user and "accidentally" found the fix for the bug while writing the bug report ^^'
      
      EDIT: Rebased for convenience, and to re-check CI.
      Unverified
      5a37518e
  7. Jun 11, 2022
    • Weslley Campos's avatar
      Chore: Add tests for agents screens (#25637) · 0d8a2aa2
      Weslley Campos authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      Add some tests for omnichannel agents screen and add some data-qa in components f
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      0d8a2aa2
Loading