Skip to content
Snippets Groups Projects
  1. Nov 19, 2024
  2. Jul 12, 2024
  3. Feb 01, 2023
  4. Jun 28, 2022
  5. Jun 08, 2022
    • Hugo Costa's avatar
      [FIX] Discussion alphabetical ordering (#25788) · 4391ca64
      Hugo Costa authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      Added a validation in the prop used for sorting (loweCaseName) checking for a prop that only exists in discussions (prid)
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      Steps to reproduce:
      
      1. Log in to the [rocket.chat](http://rocket.chat/) (version 4.8.0-rc.1)
      2. Click on the button Display and select the option Sort by : Name 
      
      Actual result:
      
      -   The discussions were not sorted by name in all types of Group: Unread, Favorites and Types 
      
      ![image](https://user-images.githubusercontent.com/20212776/172384754-3d33c76b-926b-4814-bb2f-22c7f0f914ae.png)
      
      Expected result:
      The discussions should be sorted by name
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      Unverified
      4391ca64
  6. May 09, 2022
  7. Apr 06, 2022
  8. Apr 08, 2021
  9. Oct 26, 2020
    • Guilherme Gazzo's avatar
      [IMPROVE] New sidebar layout (#19089) · edda3511
      Guilherme Gazzo authored
      
      * wip
      
      * wip
      
      * more work in progress
      
      * lint
      
      * Fix IE11 support livechat widget
      
      * More wip
      
      * lint
      
      * Add correct buttons and fix some errors
      
      * fix import
      
      * Fix error with empty department agents
      
      * fix title and tags
      
      * more fixes
      
      * fix agents save
      
      * Fix agentlist not saving
      
      * First Review
      
      * update fuselage
      
      * Sidebar variations
      
      * Fix Stories
      
      * Sidebar Header
      
      * Initial data
      
      * Fix paddings
      
      * sidebar search
      
      * Wip Chats
      
      * Added more logic
      
      * Fix Memo
      
      * Virtual List
      
      * switch to VariableSizeList
      
      * Fix Size
      
      * Te acalma Gabriel
      
      * Badges
      
      * Menu actions
      
      * Do not group by type option
      
      * Highligthed state
      
      * Fix menu
      
      * Item Skeletons
      
      * Search list
      
      * Omnichannel to virtualList
      
      * Sidebar header
      
      * SidebarHeader
      
      * Better Ominichannel Context usage
      
      * Revome livechat template
      
      * Remove discussion Room List
      
      * alert and open prop
      
      * Menu as renderprop
      
      * ReactiveUserPresence
      
      * Update components
      
      * Update cachedCollection
      
      * Fiz discussions
      
      * update cachedcolletion
      
      * Header color
      
      * Fix unread
      
      * Presence
      
      * Fix presence
      
      * Fix Admin
      
      * [wip] Search bar
      
      * get usernames in subscription
      
      * Local an spotlight search
      
      * Fix avatar id prop
      
      * Fix multi users on search
      
      * Livechat RoomMenu
      
      * Fix Header in anonymous sessions
      
      * Fix sidebar
      
      * update base old
      
      * Sidebar variations
      
      * Fix Stories
      
      * Sidebar Header
      
      * Initial data
      
      * Fix paddings
      
      * sidebar search
      
      * Wip Chats
      
      * Added more logic
      
      * Virtual List
      
      * Fix Memo
      
      * switch to VariableSizeList
      
      * Fix Size
      
      * Te acalma Gabriel
      
      * Badges
      
      * Menu actions
      
      * Do not group by type option
      
      * Highligthed state
      
      * Item Skeletons
      
      * Search list
      
      * Fix menu
      
      * Omnichannel to virtualList
      
      * Sidebar header
      
      * SidebarHeader
      
      * Better Ominichannel Context usage
      
      * Revome livechat template
      
      * Remove discussion Room List
      
      * alert and open prop
      
      * Menu as renderprop
      
      * ReactiveUserPresence
      
      * Update components
      
      * Update cachedCollection
      
      * Fiz discussions
      
      * update cachedcolletion
      
      * Header color
      
      * Fix unread
      
      * Presence
      
      * Fix presence
      
      * Fix Admin
      
      * [wip] Search bar
      
      * get usernames in subscription
      
      * Local an spotlight search
      
      * Fix avatar id prop
      
      * [FIX] Missing "Bio" in user's profile view  (#19166)
      
      * [FIX] Omnichannel: triggers page not rendering (#19134)
      
      * [FIX] VisitorAutoComplete component (#19133)
      
      * [FIX] Admin Sidebar overflowing (#19101)
      
      * [FIX] Integrations history page not reacting to changes. (#19114)
      
      * [FIX] Selecting the same department for multiple units (#19168)
      
      * [FIX] Error when editing priority and required description (#19170)
      
      * [FIX] Thread view in a channel user haven't joined (#19172)
      
      * [FIX] Livechat Appearance label and reset button (#19171)
      
      * Refactor: Omnichannel departments (#18920)
      
      Co-authored-by: default avatarGuilherme Gazzo <guilherme@gazzo.xyz>
      Co-authored-by: default avatarGabriel Henriques <gabriel.henriques@rocket.chat>
      Co-authored-by: default avatarGuilherme Gazzo <guilhermegazzo@gmail.com>
      
      * Fix multi users on search
      
      * Livechat RoomMenu
      
      * Fix Header in anonymous sessions
      
      * Fix sidebar
      
      * Fix admin user Info
      
      * update base old
      
      * fix sidebar size
      
      * Fix sidebar tests
      
      * Lint
      
      * Package-lock
      
      * package-lock
      
      * Fix callback
      
      * Removed  useless files
      
      * Fix LGTM
      
      * Isolate userpresence to dont leak react and fuselage
      
      * Fix Alert
      
      * update fuselage
      
      * fix hide modal not closing
      
      * Sort by name and activity
      
      * Fix reset
      
      * Arrow controls (#19239)
      
      Co-authored-by: default avatarGuilherme Gazzo <guilherme@gazzo.xyz>
      
      * Fixes
      
      * ActionButton
      
      * ActionButton[2]
      
      * ActionButton [3]
      
      * Support anonymous
      
      * Open menu by keyboard
      
      * Login button for anonymous users
      
      * Login button for anonymous users
      
      * Update code
      
      * ShouldUpdate
      
      * Change login Icon, fix badge
      
      * Update fuselage
      
      * Fix storybook
      
      * Fix storybook
      
      * Use Style and renamed
      
      * wip stories sidebar
      
      * Types
      
      * wip
      
      * Testing IE11
      
      * WIP
      
      * Fix Typo
      
      * Use Layout colors
      
      * Lint
      
      * Fix
      
      * Remove CallProvider
      
      * Remove CallContext
      
      Co-authored-by: default avatarMartin <martin.schoeler@rocket.chat>
      Co-authored-by: default avatarGabriel Henriques <gabriel.henriques@rocket.chat>
      Co-authored-by: default avatarDouglas Fabris <deefabris@gmail.com>
      Co-authored-by: default avatargabriellsh <40830821+gabriellsh@users.noreply.github.com>
      Co-authored-by: default avatarRenato Becker <renato.augusto.becker@gmail.com>
      Co-authored-by: default avatarTasso Evangelista <tasso.evangelista@rocket.chat>
      Unverified
      edda3511
Loading