Skip to content
Snippets Groups Projects
  1. Sep 29, 2020
    • Shiqi Mei's avatar
    • Douglas Gubert's avatar
      [NEW] Apps-Engine v1.18.0 (#19047) · 92876982
      Douglas Gubert authored
      92876982
    • Shiqi Mei's avatar
      Regression: File upload via apps not working in some scenarios (#18995) · 5f6f0022
      Shiqi Mei authored
      
      * [FIX] [Apps] Fix app user doesn't has permission to upload files
      
      * Fix errorClass [Error]: Forbidden [forbidden]
      
      In `app/file-upload/lib/FileUploadBase.js`, we configured `UploadFS.config.defaultStorePermissions`, which validates `insert(userId, doc)` etc. But the parameter userId cann't be always obtained by this validation method correctly (sometimes it's undefined). Meteor use the Meteor.userId() as its fallback option. So we can wrap the original call with `Meteor.runAsUser` to solve issue.
      
      * Add a new validator into canAccessRoom
      
      canAccessRoom (`app/authorization/server/functions/canAccessRoom.js`) is an essential validator for Rocket.Chat to check whether some user has permissions to access some room. In this PR, we added a new validator that allows app users to access any room on a Rocket.Chat server even if it is not a member of the room.
      
      *  An attempt to fix Meteor code must always run within a Fiber Error
      
      Original Error: "Error: Meteor code must always run within a Fiber. Try wrapping callbacks that you pass to non-Meteor libraries with Meteor.bindEnvironment."
      
      * Add support for uploading files by a livecaht visitor
      
      * Support upload files with livechat visitors
      
      * Reduce an unnecessary DB query - Users.findOneById
      
      * Move the "bypass" out of canAccessRoom
      
      Adding a bypass inside canAccessRoom can potentially allow apps to do stuff we're not prepared (yet)
      
      * Update Apps-Engine version
      
      * Some refactoring
      
      * Fix a rateada
      
      Co-authored-by: default avatarDouglas Gubert <douglas.gubert@gmail.com>
      5f6f0022
  2. Sep 28, 2020
  3. Sep 25, 2020
  4. Sep 23, 2020
  5. Sep 22, 2020
  6. Sep 21, 2020
  7. Sep 18, 2020
Loading