Skip to content
Snippets Groups Projects
  1. Jul 11, 2022
  2. Jun 30, 2022
  3. Jun 29, 2022
    • gabriellsh's avatar
      [FIX] Too many watchers in dev environment. (#25930) · 016584b5
      gabriellsh authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      016584b5
  4. Jun 24, 2022
    • Júlia Jaeger Foresti's avatar
      [FIX] sidebar colors (#25987) · d0f8643f
      Júlia Jaeger Foresti authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
      
      
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      
      
      Co-authored-by: default avatarGuilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
      d0f8643f
  5. Jun 23, 2022
  6. Jun 20, 2022
    • Pierre Lehnen's avatar
      Chore: Keep the option to run only the meteor app (#25915) · d0078fef
      Pierre Lehnen authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      d0078fef
  7. Jun 17, 2022
    • gabriellsh's avatar
      Chore: Watch for package changes (#25910) · 06043f52
      gabriellsh authored
      <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->
      
      <!-- Your Pull Request name should start with one of the following tags
        [NEW] For new features
        [IMPROVE] For an improvement (performance or little improvements) in existing features
        [FIX] For bug fixes that affect the end-user
        [BREAK] For pull requests including breaking changes
        Chore: For small tasks
        Doc: For documentation
      -->
      
      <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
        - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
        - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
        - Lint and unit tests pass locally with my changes
        - I have added tests that prove my fix is effective or that my feature works (if applicable)
        - I have added necessary documentation (if applicable)
        - Any dependent changes have been merged and published in downstream modules
      -->
      
      ## Proposed changes (including videos or screenshots)
      <!-- CHANGELOG -->
      <!--
        Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
        If it fixes a bug or resolves a feature request, be sure to link to that issue below.
        This description will appear in the release notes if we accept the contribution.
      -->
      With the current `dev` pipeline, whenever we modify a package (e.g. `api-client`), we have to kill the meteor proccess and run `yarn dev` again in order for the changes to be compiled and the new output to be used by meteor.
      
      This has the drawback of taking a little longer to run the dev environment, since we can't cache a watched buid. In the other hand, it reduces the friction of modifying internal packages since we don't need to rebuild the project for changes to take effect.
      
      This will enable us to move more things to separate packages without affecting the dev experience too much.
      <!-- END CHANGELOG -->
      
      ## Issue(s)
      <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
      
      ## Steps to test or reproduce
      <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->
      
      ## Further comments
      <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
      06043f52
  8. Apr 13, 2022
  9. Apr 07, 2022
  10. Apr 06, 2022
Loading