Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • asm asm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • asmasm
  • asmasm
  • Merge requests
  • !2

Fix the computation of the Label.DEBUG flag.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eric Bruneton requested to merge 317791-fix-label-debug-flag-computation into master Sep 05, 2017
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 1

The current code can incorrectly classify a Label as "used only for debug", which can yield incorrect stack map offsets due to skipped labels in MethodWriter.visitLabel (see bug #317791 (closed)). This happens when a label is found for the first time in a debug attribute (it is then flagged as DEBUG), and then appears again in a stack map frame (these labels are extracted after those from the debug attributes, during the bytecode parsing, but the DEBUG flag, if present, is not removed then).

The fix consists in removing the DEBUG flag, if present, when creating or reusing a label for non-debug attributes.

Closes #317791 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 317791-fix-label-debug-flag-computation