Hardcoded URLs (master branch)
Hello,
# frontend (master u=) $ grep -ri ow2.org
appsrc/src/environments/environment.ts: serverURL: 'https://decoder-tool.ow2.org/pkm',
appsrc/src/environments/environment.ts: asfmServerURL: 'https://decoder-tool.ow2.org/asfm',
appsrc/src/environments/environment.ts: jupyterURL: 'https://decoder-frontend.ow2.org/jupyter-hub/hub',
appsrc/src/environments/environment.ts: toolsServerUrl: 'https://decoder-tool.ow2.org/process-engine',
appsrc/src/environments/environment.docker.ts: toolsServerUrl: 'https://decoder-tool.ow2.org',
appsrc/src/environments/environment.prod.ts: serverURL: 'https://decoder-tool.ow2.org/pkm',
appsrc/src/environments/environment.prod.ts: asfmServerURL: 'https://decoder-tool.ow2.org/asfm',
appsrc/src/environments/environment.prod.ts: jupyterURL: 'https://decoder-tool.ow2.org/jupyter-lab/lab',
appsrc/src/environments/environment.prod.ts: toolsServerUrl: 'https://decoder-tool.ow2.org',
appsrc/src/app.config.json: "serverURL": "https://decoder-tool.ow2.org/pkm",
appsrc/src/app.config.json: "asfmServerURL": "https://decoder-tool.ow2.org/asfm",
appsrc/src/app.config.json: "jupyterURL": "https://decoder-frontend.ow2.org/jupyter-hub/hub",
appsrc/src/app.config.json: "toolsServerURL": "https://decoder-tool.ow2.org/process-engine"
It seems the project is using hard-coded urls and is not usable by anyone else at its current state.
The app.config.json
should be deployed dynamically by the docker image at run time. To do that, you can deploy a shell script in /docker-entrypoint.d
which will be executed at startup. I can write a MR for that if you want to.
I'm not sure about appsrc/src/environments/environment(.prod,.docker).ts
files tho, are they only used to re-create app.config.json
depending on build args ?
If so, they would become unnecessary if this file is managed dynamically at run time with a shell script in /docker-entrypoint.d
+ env variables