Skip to content

[6.2] Rewriting code on list configuration form

David Verdin requested to merge github/fork/ikedas/6.2-edit_list-rewrite-2 into sympa-6.2

Created by: ikedas

Entirely refactored edit_list_request.tt2. Simpler and consistent logic to compile configuration

Fixed bugs:

  • [SourceSup#9741] "percentage of list members in VERP mode" is order by left justified
  • Access privilege ("read" etc.) of paragraph did not override that of sub-parameter:
    • e.g. If "archive" gives "read" privilege and "archive.web_access" gives "write", latter is editable on edit_list form but change is ignored.
  • [SourceSup#7914] Web interface let define the same email twice as list owner.
  • [SourceSup#9972] Existing item in member_include list configuration paragraph cannot be removed.
  • Text parameter values including "%xx" are broken: For example "%a5" is altered to "/", "%3a" to ":".
  • and several minor flaws.

Changes:

  • List parameter "cookie" will be masked, even if it is accessible (normally by listmaster).
  • Obsoleted "date" parameter of following paragraphs: last_instantiation, creation and update.
  • Internal parameters, e.g. "creation", may not be editable.

Known bug:

  • If owner_include, editors or editor_include is empty, then [Update] on edit_list form is clicked without any changes, configuration file will be updated. This seems to be caused by inconsistency of current code to save/load config file, and may be fixed by another pr.

(6 May update) (8 May update)

Merge request reports