correct usage of invalid vs unvalid in code & messaging
the term 'unvalid', used across LL:NG 2.0.8 sources,
grep unvalid `grep -rlni unvalid .`
./lemonldap-ng-portal/t/67-CheckUser.t:# Request an unvalid identity
./lemonldap-ng-portal/t/40-Notifications-Explorer-XML-File.t: # Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/t/40-Notifications-Explorer-XML-File.t: # Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/t/40-Notifications-JSON-LDAP.t: # Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/t/40-Notifications-JSON-DBI.t: # Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/t/40-Notifications-Explorer-JSON-File.t:# Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/t/40-Notifications-Explorer-JSON-File.t:# Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/t/58-DecryptValue-with-internal-function.t: 'POST decryptvalue with unvalid value'
./lemonldap-ng-portal/t/40-Notifications-XML-DBI.t: # Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/t/40-Notifications-JSON-File.t:# Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/t/40-Notifications-JSON-File.t:# Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/t/40-Notifications-XML-File.t: # Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/t/40-Notifications-XML-File.t: # Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/t/40-Notifications-JSON-File-with-token.t:# Verify that cookie is ciphered (session unvalid)
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Lib/SAML.pm: # Send unvalidated SLO response
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/ContextSwitching.pm: 'ContextSwitching requested for an unvalid user ('
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/ContextSwitching.pm: 'ContextSwitching requested for an unvalid user ('
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/Impersonation.pm: 'Impersonation requested for an unvalid user ('
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/Impersonation.pm: 'Impersonation requested for an unvalid user ('
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/SingleSession.pm: "SingleSession called with an unvalid token");
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/CheckUser.pm: "checkUser requested for an unvalid user ($user)");
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/CheckUser.pm: 'checkUser requested for an unvalid user ('
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/GlobalLogout.pm: "GlobalLogout called with an unvalid token");
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/MailPasswordReset.pm: $self->userLogger->warn( 'Reset asked for an unvalid user ('
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/CertificateResetByMail.pm: $self->userLogger->warn( 'Reset asked for an unvalid user ('
is incorrect.
Instead it should be
- unvalid
+ invalid
The one possible exception is
./lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Lib/SAML.pm
...
3074 # Send unvalidated SLO response
return $self->sendLogoutResponseToServiceProvider( $req, $logout, $method );
...
iiuc, the intention there is to send the message if it could not be successfully validated.
for that
unvalidated
is the correct adjective.
otoh, if the intention is to communicate a successful invalidation action, then
invalidated
is more appropriate.