Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • lemonldap-ng lemonldap-ng
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 314
    • Issues 314
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LemonLDAP NGLemonLDAP NG
  • lemonldap-nglemonldap-ng
  • Issues
  • #706
Closed
Open
Issue created May 23, 2014 by FX Deltombe@fxdeltombeGuest

Forbid portal URL to be a perl expression

Since LL::NG 0.9.4, it is possible in handler and portal config to define portal URL as a perl expression, for example "http://$vhost/auth" (then, $vhost will be replaced with the request hostname, e.g. test1.example.com).

I would like to remove this feature from handler,

  • since it is undocumented (well, to be honest it is mentionned on the old wiki)
  • since it can be configured only in handler's / portal's config (that is, in PACKAGE->init parameters, and maybe in lemonldap-ng.ini ; but you can't set it in manager : it raises an error)
  • since it looks like a screwy feature (I have never had such a need)
  • and since I can't keep it if I try to pass apacheRequest as function parameters instead of as global var (needed for ##583 (closed)) - at least, I can't replace $vhost with the request hostname.

By the way, it would allow to simplify code.

Clément, could you give me your opinion / agreement ?

Assignee
Assign to
Time tracking