Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • lemonldap-ng lemonldap-ng
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 326
    • Issues 326
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LemonLDAP NGLemonLDAP NG
  • lemonldap-nglemonldap-ng
  • Merge requests
  • !322

Allow fontawesome icons to be used as application logos (#2853)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Maxime Besson requested to merge fix-application-icon-2853 into v2.0 Feb 07, 2023
  • Overview 3
  • Commits 6
  • Pipelines 2
  • Changes 29

This MR changes the behavior of applications logo.

When it contains a dot (.), nothing changes, the logo is considered to be an image file.

When it doesn't contain a dot, it is treated as a Font Awesome icons, with special template processing.

Example, replacing default LLNG icons with FA icons:

image

Manager UI has been extended:

with dot: image without dot: image

a help text links to the list of Font Awesome v4 icons:

image

Implementing this change required adding font awesome to the manager.

I did not update Font-Awesome version because the version provided by debian is stuck at 4.7.0, we should discuss this separately. Of course, a custom portal theme could use any higher version, or even a different icon pack

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-application-icon-2853